[webkit-changes] [WebKit/WebKit] c73250: Mark the unused _fullScreenEnabled SPI as deprecated

[Brent Fulgham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c732501888aa5af6413b48cdaad7c11e7a15b54f
      https://github.com/WebKit/WebKit/commit/c732501888aa5af6413b48cdaad7c11e7a15b54f
  Author: Brent Fulgham <bfulgham at apple.com>
  Date:   2024-09-10 (Tue, 10 Sep 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewAfterEnterFullscreen.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewDuringEnterFullscreen.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ExitPiPOnSuspendVideoElement.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenAlert.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenLayoutConstraints.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenRemoveNodeBeforeEnter.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSuspendAllMediaPlayback.mm
    M Tools/TestWebKitAPI/Tests/mac/FullscreenFocus.mm
    M Tools/TestWebKitAPI/Tests/mac/FullscreenPointerLeave.mm

  Log Message:
  -----------
  Mark the unused _fullScreenEnabled SPI as deprecated
https://bugs.webkit.org/show_bug.cgi?id=279237
<rdar://problem/135380328>

Reviewed by Andy Estes.

No one should be using the WKPreference class's '_fullScreenEnabled' property. This
private property no longer used, in favor of the 'elementFullscreenEnabled' API.

I noticed that some older tests still use the deprecated version of this property, so
corrected those tests to use the modern API.

There should be no behavior changes with this correction, since both properties internally modified the same state variable used to control the actual feature.

* Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewAfterEnterFullscreen.mm:
(TestWebKitAPI::TEST(CloseWebViewAfterEnterFullscreen, VideoFullscreen)):
(TestWebKitAPI::TEST(CloseWebViewAfterEnterFullscreen, ElementFullscreen)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewDuringEnterFullscreen.mm:
(TestWebKitAPI::TEST(CloseWebViewDuringEnterFullscreen, VideoFullscreen)):
(TestWebKitAPI::TEST(CloseWebViewDuringEnterFullscreen, DISABLED_ElementFullscreen)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
(TestWebKitAPI::TEST(ExitFullscreenOnEnterPiP, VideoFullscreen)):
(TestWebKitAPI::TEST(ExitFullscreenOnEnterPiP, DISABLED_ElementFullscreen)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ExitPiPOnSuspendVideoElement.mm:
(TestWebKitAPI::TEST(PictureInPicture, DISABLED_ExitPiPOnSuspendVideoElement)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenAlert.mm:
(TestWebKitAPI::TEST(Fullscreen, DISABLED_Alert)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
(TestWebKitAPI::TEST(Fullscreen, Delegate)):
(TestWebKitAPI::TEST(Fullscreen, VisibilityChangeNotDispatched)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenLayoutConstraints.mm:
(TestWebKitAPI::TEST(Fullscreen, LayoutConstraints)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenRemoveNodeBeforeEnter.mm:
(TestWebKitAPI::TEST(Fullscreen, RemoveNodeBeforeEnter)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenVideoTextRecognition.mm:
(+[FullscreenVideoTextRecognitionWebView create]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
(TestWebKitAPI::TEST(PictureInPicture, WKUIDelegate)):
(TestWebKitAPI::TEST(PictureInPicture, AudioCannotTogglePictureInPicture)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm:
(TestWebKitAPI::TEST(TopContentInset, Fullscreen)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
(TEST(WKWebViewCloseAllMediaPresentations, VideoFullscreen)):
(TEST(WKWebViewCloseAllMediaPresentations, ElementFullscreen)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSuspendAllMediaPlayback.mm:
(TEST(WKWebViewSuspendAllMediaPlayback, FullscreenWhileSuspended)):
* Tools/TestWebKitAPI/Tests/mac/FullscreenFocus.mm:
(TestWebKitAPI::TEST(Fullscreen, Focus)):
* Tools/TestWebKitAPI/Tests/mac/FullscreenPointerLeave.mm:
(TestWebKitAPI::TEST(Fullscreen, PointerLeave)):

Canonical link: https://commits.webkit.org/283421@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications