[webkit-changes] [WebKit/WebKit] 0da0ee: Web Inspector: Multiline REPL editor is broken

[Razvan Caliman - Apple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0da0eedeaa3f18bfd0bb2f1f4831f4fe3eaa4893
      https://github.com/WebKit/WebKit/commit/0da0eedeaa3f18bfd0bb2f1f4831f4fe3eaa4893
  Author: Razvan Caliman <rcaliman at apple.com>
  Date:   2024-09-10 (Tue, 10 Sep 2024)

  Changed paths:
    M Source/WebInspectorUI/UserInterface/Views/ConsoleDrawer.js
    M Source/WebInspectorUI/UserInterface/Views/Main.css
    M Source/WebInspectorUI/UserInterface/Views/QuickConsole.css
    M Source/WebInspectorUI/UserInterface/Views/QuickConsole.js
    M Source/WebInspectorUI/UserInterface/Views/Variables.css

  Log Message:
  -----------
  Web Inspector: Multiline REPL editor is broken
https://bugs.webkit.org/show_bug.cgi?id=276530
rdar://131756916

Reviewed by BJ Burg and Devin Rousso.

The content area of the console prompt is controlled by CodeMirror
which sets the dimensions of a multi-line input as you type.
It lives in a second level flex container and is intended to be capped at 33vh.

At the first level flex container, the space available to be distributed to flex items
is influenced by the size of the Console Drawer and the min-width of #tab-browser.

Due to alignment within the flex layout and insufficient space,
the multi-line console prompt nested within the second level flex container
was allowed to grow within the second-level container without causing overflow.
This masks some keyboard input and focus.

This patch ensures the maximum height of the Console Drawer takes into account the
space used by the console prompt. It also moves the 33vh max-height limit
to the first level flex container to enforce the limit and ensure a scroll container
as soon as its contents overflow.

* Source/WebInspectorUI/UserInterface/Views/ConsoleDrawer.js:
(WI.ConsoleDrawer.prototype._updateDrawerHeight):
* Source/WebInspectorUI/UserInterface/Views/Main.css:
(#content):
* Source/WebInspectorUI/UserInterface/Views/QuickConsole.css:
(.quick-console):
(.quick-console > .console-prompt):

Canonical link: https://commits.webkit.org/283412@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications