[webkit-changes] [WebKit/WebKit] 13ff8b: Scrubbing and skipping back/forward should be disa...

[aestes]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 13ff8bb8fd293373a964e479b04e4120b690c5af
      https://github.com/WebKit/WebKit/commit/13ff8bb8fd293373a964e479b04e4120b690c5af
  Author: Andy Estes <aestes at apple.com>
  Date:   2024-09-10 (Tue, 10 Sep 2024)

  Changed paths:
    M Source/WebCore/Modules/modern-media-controls/controls/time-control.js
    M Source/WebCore/Modules/modern-media-controls/controls/tvos-media-controls.css
    M Source/WebCore/Modules/modern-media-controls/media/media-controller.js
    M Source/WebCore/Modules/modern-media-controls/media/skip-back-support.js
    M Source/WebCore/Modules/modern-media-controls/media/skip-forward-support.js
    M Source/WebCore/Modules/modern-media-controls/media/time-control-support.js

  Log Message:
  -----------
  Scrubbing and skipping back/forward should be disabled in modern media controls when the host does not support seeking
https://bugs.webkit.org/show_bug.cgi?id=279095
rdar://134959242

Reviewed by Eric Carlson.

When MediaControlsHost does not support seeking, scrubbing and skip back/forward buttons should not
be available in modern media controls. Scrubbing was already disabled when in in-window fullscreen,
but this change makes scrubbing disabled elsewhere. This change also tweaks the appearance of a
disabled scrubber in tvOS media controls.

* Source/WebCore/Modules/modern-media-controls/controls/time-control.js:
(TimeControl.):
(TimeControl.prototype.set loading):
(TimeControl.prototype.get supportsSeeking):
(TimeControl.prototype.set supportsSeeking):
* Source/WebCore/Modules/modern-media-controls/controls/tvos-media-controls.css:
(.media-controls.fullscreen.tvos .slider.default.disabled > .appearance > .fill > :is(.primary, .secondary)):
* Source/WebCore/Modules/modern-media-controls/media/media-controller.js:
(MediaController.prototype._updateControlsIfNeeded):
* Source/WebCore/Modules/modern-media-controls/media/skip-back-support.js:
(SkipBackSupport.prototype.syncControl):
(SkipBackSupport):
* Source/WebCore/Modules/modern-media-controls/media/skip-forward-support.js:
(SkipForwardSupport.prototype.syncControl):
(SkipForwardSupport):
* Source/WebCore/Modules/modern-media-controls/media/time-control-support.js:
(TimeControlSupport.prototype.enable):

Canonical link: https://commits.webkit.org/283402@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications