[webkit-changes] [WebKit/WebKit] 1656a6: [Site Isolation] Cross-site iframes nested within ...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1656a6f556cdfa06e6f2e159be2465b1a934f0ad
      https://github.com/WebKit/WebKit/commit/1656a6f556cdfa06e6f2e159be2465b1a934f0ad
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-09-09 (Mon, 09 Sep 2024)

  Changed paths:
    A LayoutTests/http/tests/site-isolation/mouse-events/iframe-within-srcdoc-expected.txt
    A LayoutTests/http/tests/site-isolation/mouse-events/iframe-within-srcdoc.html
    A LayoutTests/http/tests/site-isolation/mouse-events/resources/message-top-mouse-event-type.html
    M Source/WebCore/page/EventHandler.cpp
    M Source/WebCore/page/EventHandler.h
    M Source/WebCore/page/ios/EventHandlerIOS.mm
    M Source/WebCore/page/mac/EventHandlerMac.mm
    M Source/WebCore/page/win/EventHandlerWin.cpp

  Log Message:
  -----------
  [Site Isolation] Cross-site iframes nested within same-site iframes cannot receive mouse events
https://bugs.webkit.org/show_bug.cgi?id=279398
rdar://135438488

Reviewed by Alex Christensen.

The `passMouseXEventToSubframe()` function is used to send mouse events to local iframes, but it may
later hit test an out-of-process iframe. In such cases, the function must return a
`HandleUserInputEventResult` so we can tell the UI process to forward the event.

* LayoutTests/http/tests/site-isolation/mouse-events/iframe-within-srcdoc-expected.txt: Added.
* LayoutTests/http/tests/site-isolation/mouse-events/iframe-within-srcdoc.html: Added.
* LayoutTests/http/tests/site-isolation/mouse-events/resources/message-top-mouse-event-type.html: Added.
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
* Source/WebCore/page/EventHandler.h:
* Source/WebCore/page/ios/EventHandlerIOS.mm:
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
* Source/WebCore/page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
* Source/WebCore/page/win/EventHandlerWin.cpp:
(WebCore::EventHandler::passMouseMoveEventToSubframe):

Canonical link: https://commits.webkit.org/283389@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications