[webkit-changes] [WebKit/WebKit] b6e85c: Deploy more smart pointers in Source/WebKit/UIProc...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b6e85c7bf092e2b0315d9d9e4952cd5de33033e1
      https://github.com/WebKit/WebKit/commit/b6e85c7bf092e2b0315d9d9e4952cd5de33033e1
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2024-09-09 (Mon, 09 Sep 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtension.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionAction.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionActionInternal.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionCommand.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionCommandInternal.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionContext.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionController.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionControllerConfiguration.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionControllerConfigurationInternal.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionDataRecord.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionInternal.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionMatchPattern.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionMatchPatternInternal.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionMessagePort.mm
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebPushDaemonConnection.mm
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebPushMessage.mm
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebPushSubscriptionData.mm
    M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h
    M Source/WebKit/UIProcess/Extensions/WebExtensionController.h

  Log Message:
  -----------
  Deploy more smart pointers in Source/WebKit/UIProcess/API
https://bugs.webkit.org/show_bug.cgi?id=279388

Reviewed by Timothy Hatcher.

Deployed more smart pointers in Source/WebKit/UIProcess/API as warned by the clang static analyzer.

* Source/WebKit/UIProcess/API/Cocoa/WKWebExtension.mm:
(-[WKWebExtension manifest]):
(-[WKWebExtension manifestVersion]):
(-[WKWebExtension supportsManifestVersion:]):
(-[WKWebExtension defaultLocale]):
(-[WKWebExtension displayName]):
(-[WKWebExtension displayShortName]):
(-[WKWebExtension displayVersion]):
(-[WKWebExtension displayDescription]):
(-[WKWebExtension displayActionLabel]):
(-[WKWebExtension version]):
(-[WKWebExtension iconForSize:]):
(-[WKWebExtension actionIconForSize:]):
(-[WKWebExtension requestedPermissions]):
(-[WKWebExtension optionalPermissions]):
(-[WKWebExtension requestedPermissionMatchPatterns]):
(-[WKWebExtension optionalPermissionMatchPatterns]):
(-[WKWebExtension allRequestedMatchPatterns]):
(-[WKWebExtension errors]):
(-[WKWebExtension hasBackgroundContent]):
(-[WKWebExtension hasPersistentBackgroundContent]):
(-[WKWebExtension hasInjectedContent]):
(-[WKWebExtension hasOptionsPage]):
(-[WKWebExtension hasOverrideNewTabPage]):
(-[WKWebExtension hasCommands]):
(-[WKWebExtension hasContentModificationRules]):
(-[WKWebExtension _hasServiceWorkerBackgroundContent]):
(-[WKWebExtension _hasModularBackgroundContent]):
(-[WKWebExtension _protectedWebExtension]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionAction.mm:
(-[WKWebExtensionAction webExtensionContext]):
(-[WKWebExtensionAction associatedTab]):
(-[WKWebExtensionAction iconForSize:]):
(-[WKWebExtensionAction label]):
(-[WKWebExtensionAction badgeText]):
(-[WKWebExtensionAction hasUnreadBadgeText]):
(-[WKWebExtensionAction setHasUnreadBadgeText:]):
(-[WKWebExtensionAction inspectionName]):
(-[WKWebExtensionAction setInspectionName:]):
(-[WKWebExtensionAction isEnabled]):
(-[WKWebExtensionAction menuItems]):
(-[WKWebExtensionAction presentsPopup]):
(-[WKWebExtensionAction popupViewController]):
(-[WKWebExtensionAction popupPopover]):
(-[WKWebExtensionAction popupWebView]):
(-[WKWebExtensionAction closePopup]):
(-[WKWebExtensionAction _protectedWebExtensionAction]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionActionInternal.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionCommand.mm:
(-[WKWebExtensionCommand debugDescription]):
(-[WKWebExtensionCommand webExtensionContext]):
(-[WKWebExtensionCommand setActivationKey:]):
(-[WKWebExtensionCommand modifierFlags]):
(-[WKWebExtensionCommand setModifierFlags:]):
(-[WKWebExtensionCommand menuItem]):
(-[WKWebExtensionCommand _shortcut]):
(-[WKWebExtensionCommand _userVisibleShortcut]):
(-[WKWebExtensionCommand _matchesEvent:]):
(-[WKWebExtensionCommand _protectedWebExtensionCommand]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionCommandInternal.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionContext.mm:
(-[WKWebExtensionContext initForExtension:]):
(-[WKWebExtensionContext webExtension]):
(-[WKWebExtensionContext permissionStatusForMatchPattern:inTab:]):
(-[WKWebExtensionContext setPermissionStatus:forMatchPattern:expirationDate:]):
(-[WKWebExtensionContext performCommand:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionController.mm:
(-[WKWebExtensionController initWithConfiguration:]):
(-[WKWebExtensionController configuration]):
(-[WKWebExtensionController extensionContextForExtension:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionControllerConfiguration.mm:
(-[WKWebExtensionControllerConfiguration copyWithZone:]):
(-[WKWebExtensionControllerConfiguration identifier]):
(-[WKWebExtensionControllerConfiguration webViewConfiguration]):
(-[WKWebExtensionControllerConfiguration setWebViewConfiguration:]):
(-[WKWebExtensionControllerConfiguration defaultWebsiteDataStore]):
(-[WKWebExtensionControllerConfiguration setDefaultWebsiteDataStore:]):
(-[WKWebExtensionControllerConfiguration _protectedWebExtensionControllerConfiguration]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionControllerConfigurationInternal.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionDataRecord.mm:
(-[WKWebExtensionDataRecord containedDataTypes]):
(-[WKWebExtensionDataRecord totalSizeInBytes]):
(-[WKWebExtensionDataRecord sizeInBytesOfTypes:]):
(-[WKWebExtensionDataRecord errors]):
(-[WKWebExtensionDataRecord _protectedWebExtensionDataRecord]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionInternal.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionMatchPattern.mm:
(-[WKWebExtensionMatchPattern scheme]):
(-[WKWebExtensionMatchPattern host]):
(-[WKWebExtensionMatchPattern path]):
(-[WKWebExtensionMatchPattern string]):
(-[WKWebExtensionMatchPattern matchesAllHosts]):
(-[WKWebExtensionMatchPattern matchesURL:options:]):
(-[WKWebExtensionMatchPattern matchesPattern:options:]):
(-[WKWebExtensionMatchPattern _protectedWebExtensionMatchPattern]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionMatchPatternInternal.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionMessagePort.mm:
(-[WKWebExtensionMessagePort isDisconnected]):
(-[WKWebExtensionMessagePort sendMessage:completionHandler:]):
(-[WKWebExtensionMessagePort disconnectWithError:]):
(-[WKWebExtensionMessagePort _protectedWebExtensionMessagePort]):
* Source/WebKit/UIProcess/API/Cocoa/_WKWebPushDaemonConnection.mm:
(-[_WKWebPushDaemonConnection getPushPermissionStateForOrigin:completionHandler:]):
(-[_WKWebPushDaemonConnection requestPushPermissionForOrigin:completionHandler:]):
(-[_WKWebPushDaemonConnection setAppBadge:origin:]):
(-[_WKWebPushDaemonConnection subscribeToPushServiceForScope:applicationServerKey:completionHandler:]):
(-[_WKWebPushDaemonConnection unsubscribeFromPushServiceForScope:completionHandler:]):
(-[_WKWebPushDaemonConnection getSubscriptionForScope:completionHandler:]):
(-[_WKWebPushDaemonConnection getNextPendingPushMessage:]):
(-[_WKWebPushDaemonConnection _protectedConnection]):
* Source/WebKit/UIProcess/API/Cocoa/_WKWebPushMessage.mm:
(-[_WKWebPushMessage data]):
(-[_WKWebPushMessage _protectedMessage]):
* Source/WebKit/UIProcess/API/Cocoa/_WKWebPushSubscriptionData.mm:
(-[_WKWebPushSubscriptionData endpoint]):
(-[_WKWebPushSubscriptionData applicationServerKey]):
(-[_WKWebPushSubscriptionData authenticationSecret]):
(-[_WKWebPushSubscriptionData ecdhPublicKey]):
(-[_WKWebPushSubscriptionData _protectedData]):
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.h:
(WebKit::WebExtensionContext::protectedExtension const):
* Source/WebKit/UIProcess/Extensions/WebExtensionController.h:
(WebKit::WebExtensionController::protectedConfiguration const):

Canonical link: https://commits.webkit.org/283385@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications