[webkit-changes] [WebKit/WebKit] c1309e: [JSC] Use get_internal_field bytecode instead of f...

Yusuke Suzuki noreply at github.com
Mon Sep 9 12:14:06 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c1309ede3a65c5339009da87d848b3fdc4d420e8
      https://github.com/WebKit/WebKit/commit/c1309ede3a65c5339009da87d848b3fdc4d420e8
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-09-09 (Mon, 09 Sep 2024)

  Changed paths:
    M Source/JavaScriptCore/builtins/AsyncFromSyncIteratorPrototype.js
    M Source/JavaScriptCore/builtins/BuiltinNames.h
    M Source/JavaScriptCore/builtins/WrapForValidIteratorPrototype.js
    M Source/JavaScriptCore/bytecode/BytecodeIntrinsicRegistry.cpp
    M Source/JavaScriptCore/bytecode/BytecodeIntrinsicRegistry.h
    M Source/JavaScriptCore/bytecode/LinkTimeConstant.h
    M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp
    M Source/JavaScriptCore/runtime/JSAsyncFromSyncIterator.cpp
    M Source/JavaScriptCore/runtime/JSAsyncFromSyncIterator.h
    M Source/JavaScriptCore/runtime/JSGlobalObject.cpp
    M Source/JavaScriptCore/runtime/JSWrapForValidIterator.cpp
    M Source/JavaScriptCore/runtime/JSWrapForValidIterator.h

  Log Message:
  -----------
  [JSC] Use get_internal_field bytecode instead of functions
https://bugs.webkit.org/show_bug.cgi?id=279338
rdar://135527404

Reviewed by Keith Miller.

This patch removes JSAsyncFromSyncIterator / JSWrapForValidIterator's
functions to access to its internal fields from JS. We should just use
bytecode intrinsic and get_internal_field bytecode.

* Source/JavaScriptCore/builtins/AsyncFromSyncIteratorPrototype.js:
(return):
(throw):
* Source/JavaScriptCore/builtins/BuiltinNames.h:
* Source/JavaScriptCore/builtins/WrapForValidIteratorPrototype.js:
(next):
(return):
* Source/JavaScriptCore/bytecode/BytecodeIntrinsicRegistry.cpp:
(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):
* Source/JavaScriptCore/bytecode/BytecodeIntrinsicRegistry.h:
* Source/JavaScriptCore/bytecode/LinkTimeConstant.h:
* Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:
(JSC::asyncFromSyncIteratorInternalFieldIndex):
(JSC::wrapForValidIteratorInternalFieldIndex):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_getAsyncFromSyncIteratorInternalField):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_getWrapForValidIteratorInternalField):
* Source/JavaScriptCore/runtime/JSAsyncFromSyncIterator.cpp:
* Source/JavaScriptCore/runtime/JSAsyncFromSyncIterator.h:
* Source/JavaScriptCore/runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
* Source/JavaScriptCore/runtime/JSWrapForValidIterator.cpp:
* Source/JavaScriptCore/runtime/JSWrapForValidIterator.h:

Canonical link: https://commits.webkit.org/283357@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list