[webkit-changes] [WebKit/WebKit] 5d09b5: [user-activation] Fix html/user-activation/activat...

Abrar Rahman Protyasha noreply at github.com
Mon Sep 9 11:27:05 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5d09b59ae940f8112b565b1b8c32e60135f15bb2
      https://github.com/WebKit/WebKit/commit/5d09b59ae940f8112b565b1b8c32e60135f15bb2
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-09-09 (Mon, 09 Sep 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Automation/Automation.json
    M Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp
    M Source/WebKit/UIProcess/Automation/WebAutomationSession.h
    M Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp
    M Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.h
    M Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.js
    M Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.messages.in

  Log Message:
  -----------
  [user-activation] Fix html/user-activation/activation-trigger-pointerevent.html WPT
https://bugs.webkit.org/show_bug.cgi?id=259028
rdar://111970701

Reviewed by Wenson Hsieh.

This commit introduces the ability to force user gesture on script
execution in WebAutomationSession, so we can be deliberate about which
Automation Protocol script requires user gesture, rather than the older
behavior of backing every script execution with a user gesture.

This addresses the
html/user-activation/activation-trigger-pointerevent.html WPT failure
because now the user gesture backing arbitrary web automation script
execution does not fight against the user activation required to
exercise the fullscreen API.

* Source/WebKit/UIProcess/Automation/Automation.json:
* Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::evaluateJavaScriptFunction):
* Source/WebKit/UIProcess/Automation/WebAutomationSession.h:
* Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::evaluateJavaScriptFunction):
* Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.h:
* Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.js:
* Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.messages.in:

Canonical link: https://commits.webkit.org/283353@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list