[webkit-changes] [WebKit/WebKit] 5b689e: CSS counter-* should not eagerly evaluate calc()

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5b689e6770dcfa551c1f493bcf9d1bee7c79c95c
      https://github.com/WebKit/WebKit/commit/5b689e6770dcfa551c1f493bcf9d1bee7c79c95c
  Author: Sam Weinig <sam at webkit.org>
  Date:   2024-09-09 (Mon, 09 Sep 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/counter-increment-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/counter-increment-valid.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/counter-reset-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/counter-reset-valid.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/counter-set-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/counter-set-valid.html
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/css/CSSCounterStyle.cpp
    M Source/WebCore/css/CSSCounterStyleRule.cpp
    M Source/WebCore/css/parser/CSSParserImpl.cpp
    A Source/WebCore/css/parser/CSSPropertyParserConsumer+CounterStyles.cpp
    A Source/WebCore/css/parser/CSSPropertyParserConsumer+CounterStyles.h
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+Filter.cpp
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+Filter.h
    A Source/WebCore/css/parser/CSSPropertyParserConsumer+Lists.cpp
    A Source/WebCore/css/parser/CSSPropertyParserConsumer+Lists.h
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
    M Source/WebCore/css/process-css-properties.py

  Log Message:
  -----------
  CSS counter-* should not eagerly evaluate calc()
https://bugs.webkit.org/show_bug.cgi?id=279326

Reviewed by Darin Adler.

Replaces eager evaluation of calc() in counter-set, counter-increment, and
counter-reset, with storing the primitive value for resolution at style
building time.

Also took opportunity to move CSS List and CSS Counter Style consumers
to their own files.

* LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/counter-increment-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/counter-increment-valid.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/counter-reset-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/counter-reset-valid.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/counter-set-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/counter-set-valid.html:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSCounterStyle.cpp:
* Source/WebCore/css/CSSCounterStyleRule.cpp:
* Source/WebCore/css/parser/CSSParserImpl.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+CounterStyles.cpp: Added.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+CounterStyles.h: Added.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Lists.cpp: Added.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Lists.h: Added.
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebCore/css/process-css-properties.py:

Canonical link: https://commits.webkit.org/283340@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications