[webkit-changes] [WebKit/WebKit] 39d292: Fix NoUncountedMemberChecker warnings in WebScreen...

Ryosuke Niwa noreply at github.com
Sun Sep 8 23:05:19 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 39d2925d59524e6104e93f5b1b08eb6b7e3dc781
      https://github.com/WebKit/WebKit/commit/39d2925d59524e6104e93f5b1b08eb6b7e3dc781
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2024-09-08 (Sun, 08 Sep 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.cpp
    M Source/WebKit/WebProcess/Model/WebModelPlayerProvider.cpp
    M Source/WebKit/WebProcess/Model/WebModelPlayerProvider.h
    M Source/WebKit/WebProcess/WebCoreSupport/WebSpeechSynthesisClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebSpeechSynthesisClient.h

  Log Message:
  -----------
  Fix NoUncountedMemberChecker warnings in WebScreenOrientationManagerProxy, WebModelPlayerProvider, and WebSpeechSynthesisClient.
https://bugs.webkit.org/show_bug.cgi?id=279286

Reviewed by Chris Dumez.

Use more smart pointers for member variables in these classes.

* Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.cpp:
(WebKit::WebScreenOrientationManagerProxy::WebScreenOrientationManagerProxy):
(WebKit::WebScreenOrientationManagerProxy::~WebScreenOrientationManagerProxy):
(WebKit::WebScreenOrientationManagerProxy::setCurrentOrientation):
(WebKit::WebScreenOrientationManagerProxy::lock):
(WebKit::WebScreenOrientationManagerProxy::unlock):
* Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.h:
* Source/WebKit/WebProcess/Model/WebModelPlayerProvider.cpp:
(WebKit::WebModelPlayerProvider::createModelPlayer):
* Source/WebKit/WebProcess/Model/WebModelPlayerProvider.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebSpeechSynthesisClient.cpp:
(WebKit::WebSpeechSynthesisClient::WebSpeechSynthesisClient):
(WebKit::WebSpeechSynthesisClient::protectedPage const):
(WebKit::WebSpeechSynthesisClient::voiceList):
(WebKit::WebSpeechSynthesisClient::corePageObserver const):
(WebKit::WebSpeechSynthesisClient::resetState):
(WebKit::WebSpeechSynthesisClient::speak):
(WebKit::WebSpeechSynthesisClient::cancel):
(WebKit::WebSpeechSynthesisClient::pause):
(WebKit::WebSpeechSynthesisClient::resume):
* Source/WebKit/WebProcess/WebCoreSupport/WebSpeechSynthesisClient.h:
(WebKit::WebSpeechSynthesisClient::WebSpeechSynthesisClient): Deleted.

Canonical link: https://commits.webkit.org/283330@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list