[webkit-changes] [WebKit/WebKit] 585d6a: REGRESSION (iOS 17.x): Ellipses do not appear when...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 585d6a47c46e744837a3cd36a63099da6b762db7
      https://github.com/WebKit/WebKit/commit/585d6a47c46e744837a3cd36a63099da6b762db7
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-09-08 (Sun, 08 Sep 2024)

  Changed paths:
    A LayoutTests/fast/multicol/multicol-with-line-clamp-missing-ellipsis-expected.html
    A LayoutTests/fast/multicol/multicol-with-line-clamp-missing-ellipsis.html
    M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp

  Log Message:
  -----------
  REGRESSION (iOS 17.x): Ellipses do not appear when column-count and line-clamp are used together
https://bugs.webkit.org/show_bug.cgi?id=279110
<rdar://problem/135291399>

Reviewed by Antti Koivisto.

This patch ensures that whenever there's line clamp on a multicol content, we don't re-run layout outside of the
line-clamp context. This happened to work with legacy line-clamp implementation as ellipsis box was sticky (re-layout did not remove it)
while IFC only puts ellipsis when we tell it to.

* LayoutTests/fast/multicol/multicol-with-line-clamp-missing-ellipsis-expected.html: Added.
* LayoutTests/fast/multicol/multicol-with-line-clamp-missing-ellipsis.html: Added.
* Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):

Canonical link: https://commits.webkit.org/283326@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications