[webkit-changes] [WebKit/WebKit] cef722: CSS cursor should not eagerly evaluate calc() values

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cef722bf55c74c09ac0fc5eec4a35674ab09b977
      https://github.com/WebKit/WebKit/commit/cef722bf55c74c09ac0fc5eec4a35674ab09b977
  Author: Sam Weinig <sam at webkit.org>
  Date:   2024-09-08 (Sun, 08 Sep 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/cursor-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/cursor-valid.html
    M Source/WebCore/css/CSSCursorImageValue.cpp
    M Source/WebCore/css/CSSCursorImageValue.h
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/rendering/style/StyleCursorImage.cpp
    M Source/WebCore/rendering/style/StyleCursorImage.h
    M Source/WebCore/style/StyleBuilderCustom.h

  Log Message:
  -----------
  CSS cursor should not eagerly evaluate calc() values
https://bugs.webkit.org/show_bug.cgi?id=279319

Reviewed by Darin Adler.

Replace eager evaluation of calc() for the x/y coordinates
in CSS cursor values with normal storage or primitive values
and resolution at style building.

Retained existing casting from double -> int rather than
rounding to minimize changes.

* LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/cursor-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/cursor-valid.html:
    - Add tests showing retaining calc for specified value.

* Source/WebCore/css/CSSCursorImageValue.cpp:
* Source/WebCore/css/CSSCursorImageValue.h:
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
* Source/WebCore/rendering/style/StyleCursorImage.cpp:
* Source/WebCore/rendering/style/StyleCursorImage.h:
* Source/WebCore/style/StyleBuilderCustom.h:

Canonical link: https://commits.webkit.org/283316@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications