[webkit-changes] [WebKit/WebKit] bb65b6: Remove local `media` tests in favor of WPT

Ahmad Saleem noreply at github.com
Sun Sep 8 01:17:19 PDT 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bb65b6bc492f39397875255dd0e1d124e1b03484
      https://github.com/WebKit/WebKit/commit/bb65b6bc492f39397875255dd0e1d124e1b03484
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-09-08 (Sun, 08 Sep 2024)

  Changed paths:
    A LayoutTests/media/resources/white.mp4
    A LayoutTests/media/resources/white.webm
    R LayoutTests/media/track/getCueAsHTMLCrash-expected.txt
    R LayoutTests/media/track/getCueAsHTMLCrash.html
    R LayoutTests/media/track/opera/idl/media-idl-tests.html
    R LayoutTests/media/track/opera/interfaces/HTMLElement/HTMLTrackElement/src.html
    R LayoutTests/media/track/opera/interfaces/TextTrackCue/getCueAsHTML.html
    R LayoutTests/media/track/opera/interfaces/TextTrackCue/line.html
    R LayoutTests/media/track/opera/interfaces/TextTrackCue/snapToLines.html
    R LayoutTests/media/track/opera/interfaces/TextTrackCue/text.html
    R LayoutTests/media/track/opera/interfaces/TextTrackCue/vertical.html
    R LayoutTests/media/track/opera/resources/WebIDLParser.js
    R LayoutTests/media/track/opera/resources/idlharness.js
    R LayoutTests/media/track/track-default-attribute-expected.txt
    R LayoutTests/media/track/track-default-attribute.html
    M LayoutTests/media/track/track-webvtt-no-snap-to-lines-overlap-expected.html
    M LayoutTests/media/track/track-webvtt-no-snap-to-lines-overlap.html
    M LayoutTests/media/track/track-webvtt-snap-to-lines-inline-style-expected.html
    M LayoutTests/media/track/track-webvtt-snap-to-lines-inline-style.html
    M LayoutTests/media/track/track-webvtt-snap-to-lines-left-right-expected.html
    M LayoutTests/media/track/track-webvtt-snap-to-lines-left-right.html
    R LayoutTests/media/track/w3c/interfaces/TextTrack/cues-expected.txt
    R LayoutTests/media/track/w3c/interfaces/TextTrack/cues.html
    R LayoutTests/media/track/w3c/interfaces/TextTrackCue/align-expected.txt
    R LayoutTests/media/track/w3c/interfaces/TextTrackCue/align.html
    R LayoutTests/media/track/w3c/track/webvtt/2_tracks-expected.html
    R LayoutTests/media/track/w3c/track/webvtt/2_tracks.html
    R LayoutTests/media/track/w3c/track/webvtt/align_end-expected.html
    R LayoutTests/media/track/w3c/track/webvtt/align_end.html
    R LayoutTests/media/track/w3c/track/webvtt/align_middle-expected.html
    R LayoutTests/media/track/w3c/track/webvtt/align_middle.html
    R LayoutTests/media/track/w3c/track/webvtt/align_middle_position_50-expected.html
    R LayoutTests/media/track/w3c/track/webvtt/align_middle_position_50.html
    R LayoutTests/media/track/w3c/track/webvtt/align_middle_position_gt_50-expected.html
    R LayoutTests/media/track/w3c/track/webvtt/align_middle_position_gt_50.html
    R LayoutTests/media/track/w3c/track/webvtt/align_middle_position_lt_50-expected.html
    R LayoutTests/media/track/w3c/track/webvtt/align_middle_position_lt_50.html
    R LayoutTests/media/track/w3c/track/webvtt/align_middle_position_lt_50_size_gt_maximum_size-expected.html
    R LayoutTests/media/track/w3c/track/webvtt/align_middle_position_lt_50_size_gt_maximum_size.html
    R LayoutTests/media/track/w3c/track/webvtt/align_start-expected.html
    R LayoutTests/media/track/w3c/track/webvtt/align_start.html
    R LayoutTests/media/track/w3c/track/webvtt/audio_has_no_subtitles-expected.html
    R LayoutTests/media/track/w3c/track/webvtt/audio_has_no_subtitles.html
    R LayoutTests/media/track/w3c/track/webvtt/background.gif
    R LayoutTests/media/track/w3c/track/webvtt/basic-expected.html
    R LayoutTests/media/track/w3c/track/webvtt/basic.html
    R LayoutTests/media/track/w3c/track/webvtt/decode_escaped_entities-expected.html
    R LayoutTests/media/track/w3c/track/webvtt/decode_escaped_entities.html
    R LayoutTests/media/track/w3c/track/webvtt/dom_override_cue_align_position_line_size-expected.html
    R LayoutTests/media/track/w3c/track/webvtt/dom_override_cue_align_position_line_size.html
    R LayoutTests/media/track/w3c/track/webvtt/dom_override_cue_align_position_line_size_while_paused-expected.html
    R LayoutTests/media/track/w3c/track/webvtt/dom_override_cue_align_position_line_size_while_paused.html
    R LayoutTests/media/track/w3c/track/webvtt/dom_override_cue_text-expected.html
    R LayoutTests/media/track/w3c/track/webvtt/dom_override_cue_text.html
    R LayoutTests/media/track/w3c/track/webvtt/dom_override_cue_text_while_paused-expected.html
    R LayoutTests/media/track/w3c/track/webvtt/dom_override_cue_text_while_paused.html
    R LayoutTests/media/track/w3c/track/webvtt/dom_override_remove_cue_while_paused-expected.html
    R LayoutTests/media/track/w3c/track/webvtt/dom_override_remove_cue_while_paused.html
    R LayoutTests/media/track/w3c/track/webvtt/media/white.mp4
    R LayoutTests/media/track/w3c/track/webvtt/media/white.webm
    R LayoutTests/media/track/w3c/track/webvtt/one_line_cue_plus_wrapped_cue-expected.html
    R LayoutTests/media/track/w3c/track/webvtt/one_line_cue_plus_wrapped_cue.html
    R LayoutTests/media/track/w3c/track/webvtt/size_50-expected.html
    R LayoutTests/media/track/w3c/track/webvtt/size_50.html
    R LayoutTests/media/track/w3c/track/webvtt/support/2_cues_overlapping_completely_move_up.vtt
    R LayoutTests/media/track/w3c/track/webvtt/support/align_end_long.vtt
    R LayoutTests/media/track/w3c/track/webvtt/support/foo.vtt
    R LayoutTests/media/track/w3c/track/webvtt/support/refTestWait.js
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/mac/TestExpectations

  Log Message:
  -----------
  Remove local `media` tests in favor of WPT

https://bugs.webkit.org/show_bug.cgi?id=278985
rdar://problem/135106273

Reviewed by Eric Carlson.

This patch is continuation of clean-up of `media` directory to reduce
duplicate tests (which were upstreamed to WPT and we have them in tree).

> getCueAsHTMLCrash.html was duplicated in `TextTrack` and `WebVTT`, it
was cleaned-up to be in `WebVTT` only and then renamed to below:
getCueAsHTMLCrash.html -> constructor-exceptions.html
Blink Reference: https://chromium.googlesource.com/chromium/src.git/+/556a37dd198807501fbdc550fc0e2960883e8647

> media-idl-tests.html -> covered by dom/inhterfaces.html
Reference: https://github.com/web-platform-tests/wpt/commit/cb28b226a8d2f1d77dd522f3312416450bac4f7e

> src.html -> covered via same name in `HTMLTrackElement/src.html` on WPT
> getCueAsHTML.html -> covered via same name in `WebVTT/api/VTTCue/getCueAsHTML.html` on WPT
> line.html -> covered via same name in above directory on WPT
> snapToLines.html -> covered via same name in above directory on WPT
> text.html -> covered via same name in above directory on WPT
> vertical.html -> covered via same name in above directory on WPT

> track-default-attribute.html -> same name in `track/track-element` on WPT

> cues.html -> same name in `interfaces/TextTrack` on WPT
> align.html -> covered via same name in above directory on WPT

All `media/track/w3c/track/webvtt` are now in `webvtt/rendering/cues-with-video`,
refer:

WPT Reference: https://github.com/web-platform-tests/wpt/pull/4385

* LayoutTests/media/track/getCueAsHTMLCrash-expected.txt: Removed.
* LayoutTests/media/track/getCueAsHTMLCrash.html: Removed.
* LayoutTests/media/track/opera/idl/media-idl-tests.html: Removed.
* LayoutTests/media/track/opera/interfaces/HTMLElement/HTMLTrackElement/src.html: Removed.
* LayoutTests/media/track/opera/interfaces/TextTrackCue/getCueAsHTML.html: Removed.
* LayoutTests/media/track/opera/interfaces/TextTrackCue/line.html: Removed.
* LayoutTests/media/track/opera/interfaces/TextTrackCue/snapToLines.html: Removed.
* LayoutTests/media/track/opera/interfaces/TextTrackCue/text.html: Removed.
* LayoutTests/media/track/opera/interfaces/TextTrackCue/vertical.html: Removed.
* LayoutTests/media/track/opera/resources/WebIDLParser.js: Removed.
* LayoutTests/media/track/opera/resources/idlharness.js: Removed.
* LayoutTests/media/track/track-default-attribute-expected.txt: Removed.
* LayoutTests/media/track/track-default-attribute.html: Removed.
* LayoutTests/media/track/w3c/interfaces/TextTrack/cues-expected.txt: Removed.
* LayoutTests/media/track/w3c/interfaces/TextTrack/cues.html: Removed.
* LayoutTests/media/track/w3c/interfaces/TextTrackCue/align-expected.txt: Removed.
* LayoutTests/media/track/w3c/interfaces/TextTrackCue/align.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/2_tracks-expected.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/2_tracks.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/align_end-expected.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/align_end.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/align_middle-expected.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/align_middle.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/align_middle_position_50-expected.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/align_middle_position_50.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/align_middle_position_gt_50-expected.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/align_middle_position_gt_50.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/align_middle_position_lt_50-expected.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/align_middle_position_lt_50.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/align_middle_position_lt_50_size_gt_maximum_size-expected.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/align_middle_position_lt_50_size_gt_maximum_size.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/align_start-expected.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/align_start.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/audio_has_no_subtitles-expected.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/audio_has_no_subtitles.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/background.gif: Removed.
* LayoutTests/media/track/w3c/track/webvtt/basic-expected.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/basic.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/decode_escaped_entities-expected.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/decode_escaped_entities.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/dom_override_cue_align_position_line_size-expected.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/dom_override_cue_align_position_line_size.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/dom_override_cue_align_position_line_size_while_paused-expected.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/dom_override_cue_align_position_line_size_while_paused.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/dom_override_cue_text-expected.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/dom_override_cue_text.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/dom_override_cue_text_while_paused-expected.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/dom_override_cue_text_while_paused.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/dom_override_remove_cue_while_paused-expected.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/dom_override_remove_cue_while_paused.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/media/white.mp4: Removed.
* LayoutTests/media/track/w3c/track/webvtt/media/white.webm: Removed.
* LayoutTests/media/track/w3c/track/webvtt/one_line_cue_plus_wrapped_cue-expected.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/one_line_cue_plus_wrapped_cue.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/size_50-expected.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/size_50.html: Removed.
* LayoutTests/media/track/w3c/track/webvtt/support/2_cues_overlapping_completely_move_up.vtt: Removed.
* LayoutTests/media/track/w3c/track/webvtt/support/align_end_long.vtt: Removed.
* LayoutTests/media/track/w3c/track/webvtt/support/foo.vtt: Removed.
* LayoutTests/media/track/w3c/track/webvtt/support/refTestWait.js: Removed.
* LayoutTests/media/track/track-webvtt-no-snap-to-lines-overlap.html:
* LayoutTests/media/track/track-webvtt-snap-to-lines-inline-style.html:
* LayoutTests/media/track/track-webvtt-snap-to-lines-left-right.html:
* LayoutTests/media/resources/white.webm:
* LayoutTests/media/resources/white.mp4:
* LayoutTests/media/track/track-webvtt-no-snap-to-lines-overlap-expected.html:
* LayoutTests/media/track/track-webvtt-snap-to-lines-inline-style-expected.html:
* LayoutTests/media/track/track-webvtt-snap-to-lines-left-right-expected.html:

Canonical link: https://commits.webkit.org/283310@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list