[webkit-changes] [WebKit/WebKit] 73d6aa: Allow Length to be used with Markable<>

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 73d6aa835129f3a2deb0851e88e7fc193183549b
      https://github.com/WebKit/WebKit/commit/73d6aa835129f3a2deb0851e88e7fc193183549b
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-09-07 (Sat, 07 Sep 2024)

  Changed paths:
    M Source/WebCore/platform/Length.cpp
    M Source/WebCore/platform/Length.h
    M Source/WebCore/rendering/style/StyleRareNonInheritedData.h

  Log Message:
  -----------
  Allow Length to be used with Markable<>
https://bugs.webkit.org/show_bug.cgi?id=251758
rdar://105059616

Reviewed by Darin Adler.

Make possible Markable<Length> to avoid excess padding, and use it in StyleRareNonInheritedData.

We can use the unused byte at the end of Length, rather than polluting the LengthType enum.

Credits to Simon Fraser for the patch.

* Source/WebCore/platform/Length.cpp:
* Source/WebCore/platform/Length.h:
(WebCore::Length::isEmptyValue const):
(WebCore::Length::MarkableTraits::isEmptyValue):
(WebCore::Length::MarkableTraits::emptyValue):
(WebCore::Length::createEmptyValue):
(WebCore::Length::initialize):
(WebCore::Length::operator== const):
(WebCore::Length::value const):
(WebCore::Length::setValue):
(WebCore::Length::isNegative const):
(WebCore::Length::isPositive const):
(WebCore::Length::isZero const):
* Source/WebCore/rendering/style/StyleRareNonInheritedData.h:

Canonical link: https://commits.webkit.org/283293@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications