[webkit-changes] [WebKit/WebKit] 1ef26a: List marker incorrectly positioned when list child...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1ef26a30832896f11f8f0c076702915d27d478d2
      https://github.com/WebKit/WebKit/commit/1ef26a30832896f11f8f0c076702915d27d478d2
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-09-06 (Fri, 06 Sep 2024)

  Changed paths:
    A LayoutTests/fast/inline/list-marker-inside-container-with-margin-expected.html
    A LayoutTests/fast/inline/list-marker-inside-container-with-margin.html
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebCore/layout/integration/inline/LayoutIntegrationBoxGeometryUpdater.cpp

  Log Message:
  -----------
  List marker incorrectly positioned when list child has inline margin
https://bugs.webkit.org/show_bug.cgi?id=279172
<rdar://problem/135332538>

Reviewed by Antti Koivisto.

Let's indent list marker with the start margin value when nested inside a block container.
(This is a side effect of us trying to find a container for the inline list marker renderer when
"sibling" box is not inline (e.g. block)).

It makes WebKit's list marker position match with both Blink and Gecko.

* LayoutTests/fast/inline/list-marker-inside-container-with-margin-expected.html: Added.
* LayoutTests/fast/inline/list-marker-inside-container-with-margin.html: Added.
* Source/WebCore/layout/integration/inline/LayoutIntegrationBoxGeometryUpdater.cpp:
(WebCore::LayoutIntegration::BoxGeometryUpdater::updateListMarkerDimensions):

Canonical link: https://commits.webkit.org/283289@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications