[webkit-changes] [WebKit/WebKit] 29304d: Omitted left | right value of text-emphasis-positi...

fantasai noreply at github.com
Fri Sep 6 11:15:32 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 29304d7c911953125d52935c1281063b7157d707
      https://github.com/WebKit/WebKit/commit/29304d7c911953125d52935c1281063b7157d707
  Author: Elika Etemad <fantasai.bugs at inkedblade.net>
  Date:   2024-09-06 (Fri, 06 Sep 2024)

  Changed paths:
    M LayoutTests/fast/repaint/text-emphasis-h.html
    M LayoutTests/fast/text/emphasis-vertical-over-right-expected.html
    M LayoutTests/fast/text/emphasis-vertical-over-right.html
    M LayoutTests/fast/text/emphasis-vertical.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-emphasis-position-default-001-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-emphasis-position-default-001.html
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp
    M Source/WebCore/rendering/RenderText.cpp

  Log Message:
  -----------
  Omitted left | right value of text-emphasis-position defaults to right
https://bugs.webkit.org/show_bug.cgi?id=279217
rdar://problem/135366186

Reviewed by Alan Baradlay.

If [ left | right ] is omitted from text-emphasis-position, it defaults to right.
https://www.w3.org/TR/css-text-decor/#text-emphasis-position-property

* LayoutTests/fast/repaint/text-emphasis-h.html:
* LayoutTests/fast/text/emphasis-vertical-over-right-expected.html:
* LayoutTests/fast/text/emphasis-vertical-over-right.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-emphasis-position-default-001-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-emphasis-position-default-001.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp:
(WebCore::Layout::InlineFormattingUtils::textEmphasisForInlineBox):
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::emphasisMarkExistsAndIsAbove):

Canonical link: https://commits.webkit.org/283275@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list