[webkit-changes] [WebKit/WebKit] e7ba88: REGRESSION (282158 at main): [macOS] inspector/consol...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e7ba88dca5e7d52f7986e225ed27a6fcf5170472
      https://github.com/WebKit/WebKit/commit/e7ba88dca5e7d52f7986e225ed27a6fcf5170472
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-09-06 (Fri, 06 Sep 2024)

  Changed paths:
    M LayoutTests/platform/mac/TestExpectations
    M Source/WebCore/Modules/mediasession/MediaSession.cpp
    M Source/WebCore/Modules/mediasession/MediaSession.h

  Log Message:
  -----------
  REGRESSION (282158 at main): [macOS] inspector/console/webcore-logging.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=278052
rdar://133791485

Reviewed by Eric Carlson.

Don't add default `favicon.ico` to the list of icons to retrieve if the document is local.

Don't attempt to use favicons that aren't served over HTTP. The DocumentLoader automatically adds
a search for '/favicon.ico' of none were set in the Document.
Attempting to load a non-existent icon caused unnecessary verbosity in the web inspector's console
which caused the test to intermittently fail.

Covered by existing tests and the re-enabled one.

* LayoutTests/platform/mac/TestExpectations:
* Source/WebCore/Modules/mediasession/MediaSession.cpp:
(WebCore::fallbackArtwork):
(WebCore::MediaSession::updateNowPlayingInfo):
* Source/WebCore/Modules/mediasession/MediaSession.h:

Canonical link: https://commits.webkit.org/283269@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications