[webkit-changes] [WebKit/WebKit] 8624e0: TestIPC.ConnectionTest/ConnectionTestABBA.ReceiveA...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8624e0afed7ea1270abee7d0fb38facd81c78422
      https://github.com/WebKit/WebKit/commit/8624e0afed7ea1270abee7d0fb38facd81c78422
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2024-09-06 (Fri, 06 Sep 2024)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp

  Log Message:
  -----------
  TestIPC.ConnectionTest/ConnectionTestABBA.ReceiveAlreadyInvalidatedClientNoAssert* is consistent crash
https://bugs.webkit.org/show_bug.cgi?id=279196
rdar://131073452

Reviewed by Simon Fraser.

The test would send 800 invalidated connections and for each received
connection it would waitForDidClose. However, as waitForDidClose is
implemented as RunLoop spin, this spin could also run the message
handler for the next message instead of the didClose of the received
message. This would result in 800 deep callgraph re-entering the runloop
spin for each message. This would overflow the NSRunLoop re-entering
counts and crash.

Fix by first receiving the connections, then waiting for them
individually to prove that the didClose was run.

* Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp:
(TestWebKitAPI::TEST_P):

Canonical link: https://commits.webkit.org/283258@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications