[webkit-changes] [WebKit/WebKit] ea6f3a: REGRESSION(274563 at main): [GTK] Broke webkit_web_re...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ea6f3ad7b7046eefd8037708280b1e6138842a32
      https://github.com/WebKit/WebKit/commit/ea6f3ad7b7046eefd8037708280b1e6138842a32
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2024-09-06 (Fri, 06 Sep 2024)

  Changed paths:
    M Source/WebKit/Platform/IPC/SharedBufferReference.cpp
    M Source/WebKit/Platform/IPC/SharedBufferReference.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  REGRESSION(274563 at main): [GTK] Broke webkit_web_resource_get_data() on https://register.gitlab.gnome.org/
https://bugs.webkit.org/show_bug.cgi?id=275087

Reviewed by Chris Dumez.

Always make the buffer contiguous in SharedBufferReference::span() if
needed. The callers of SharedBufferReference::span() always expect the
buffer data without having to know whether the internal buffer is
contiguous or not.

* Source/WebKit/Platform/IPC/SharedBufferReference.cpp:
(IPC::SharedBufferReference::span const):
* Source/WebKit/Platform/IPC/SharedBufferReference.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getLoadDecisionForIcon):

Canonical link: https://commits.webkit.org/283254@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications