[webkit-changes] [WebKit/WebKit] 371169: Cherry-pick 282482 at main (c208d4a122c6). https://bu...

[Adrian Perez]

  Branch: refs/heads/webkitglib/2.46
  Home:   https://github.com/WebKit/WebKit
  Commit: 371169fd5da4aa66f1cc94a9abb63c9a406944db
      https://github.com/WebKit/WebKit/commit/371169fd5da4aa66f1cc94a9abb63c9a406944db
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-09-04 (Wed, 04 Sep 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm

  Log Message:
  -----------
  Cherry-pick 282482 at main (c208d4a122c6). https://bugs.webkit.org/show_bug.cgi?id=278359

    REGRESSION (274396 at main): UI Process COOP check should only remove opener during main frame navigations
    https://bugs.webkit.org/show_bug.cgi?id=278359
    rdar://132840366

    Reviewed by Matthew Finkel.

    We have COOP header checks in the network process and web process, and in 274396 at main I introduced one
    in the UI process.  However, the other two checks have this comment:
    // COOP only applies to top-level browsing contexts.
    I missed adding that check in the UI process.  As a result, if there is an iframe loaded with a COOP header
    (which should be ignored), then a cross-origin navigation, then another cross-origin navigation back,
    the opener should be there but we had removed it.  The regression caused a login flow to break.

    I manually verified the login flow is fixed with this change, and I added a unit test that hits this condition.

    * Source/WebKit/UIProcess/WebPageProxy.cpp:
    (WebKit::WebPageProxy::decidePolicyForResponseShared):
    * Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
    ((ProcessSwap, ClientRedirectAfterCOOPIframeIgnored)):

    Canonical link: https://commits.webkit.org/282482@main


  Commit: b34dd0edac3b873ef4c7814555f439ff60593ba9
      https://github.com/WebKit/WebKit/commit/b34dd0edac3b873ef4c7814555f439ff60593ba9
  Author: Adrian Perez de Castro <aperez at igalia.com>
  Date:   2024-09-06 (Fri, 06 Sep 2024)

  Changed paths:
    M Source/WebKit/wpe/NEWS
    M Source/cmake/OptionsWPE.cmake

  Log Message:
  -----------
  Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.45.90 release
Need the bug URL (OOPS!).

* Source/WebKit/wpe/NEWS: Add release notes for 2.45.90
* Source/cmake/OptionsWPE.cmake: Bump version numbers.


Compare: https://github.com/WebKit/WebKit/compare/e5b56d46bc20...b34dd0edac3b

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications