[webkit-changes] [WebKit/WebKit] 6fc8b2: 282972 at main removed some valid PDF layout tests

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6fc8b2f924e98fcdc547866599da52fc6136a9ec
      https://github.com/WebKit/WebKit/commit/6fc8b2f924e98fcdc547866599da52fc6136a9ec
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-09-05 (Thu, 05 Sep 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/pdf/annotations/checkbox-set-active-expected.html
    A LayoutTests/pdf/annotations/checkbox-set-active.html
    A LayoutTests/pdf/annotations/dropdown-select-second-option-expected.html
    A LayoutTests/pdf/annotations/dropdown-select-second-option.html
    A LayoutTests/pdf/annotations/radio-buttons-select-second-expected.html
    A LayoutTests/pdf/annotations/radio-buttons-select-second.html
    A LayoutTests/pdf/images/jpeg2000-embed-pdf-expected.html
    A LayoutTests/pdf/images/jpeg2000-embed-pdf.html
    A LayoutTests/pdf/pdf-in-embed-expected.txt
    A LayoutTests/pdf/pdf-in-embed-rounded-border-expected.html
    A LayoutTests/pdf/pdf-in-embed-rounded-border.html
    A LayoutTests/pdf/pdf-in-embed-with-root-page-zoom-expected.txt
    A LayoutTests/pdf/pdf-in-embed-with-root-page-zoom.html
    A LayoutTests/pdf/pdf-in-embed.html
    A LayoutTests/pdf/pdf-in-iframe-scrolling-tree-after-back-expected.txt
    A LayoutTests/pdf/pdf-in-iframe-scrolling-tree-after-back.html
    A LayoutTests/pdf/pdf-in-styled-embed-expected.txt
    A LayoutTests/pdf/pdf-in-styled-embed.html
    A LayoutTests/pdf/pdf-plugin-hang-during-destruction-expected.txt
    A LayoutTests/pdf/pdf-plugin-hang-during-destruction.html
    A LayoutTests/pdf/pdf-plugin-null-onloaddeddata-expected.txt
    A LayoutTests/pdf/pdf-plugin-null-onloaddeddata.html
    A LayoutTests/pdf/pdf-plugin-printing-expected.txt
    A LayoutTests/pdf/pdf-plugin-printing.html
    A LayoutTests/pdf/pdf-scrolling-tree-dynamic-expected.txt
    A LayoutTests/pdf/pdf-scrolling-tree-dynamic.html
    A LayoutTests/pdf/pdf-scrolling-tree-expected.txt
    A LayoutTests/pdf/pdf-scrolling-tree.html
    A LayoutTests/pdf/resources/400x400-green-jpeg2000.pdf
    A LayoutTests/pdf/resources/annotation-checkbox-active.pdf
    A LayoutTests/pdf/resources/annotation-checkbox-inactive.pdf
    A LayoutTests/pdf/resources/annotation-dropdown-first-option-selected.pdf
    A LayoutTests/pdf/resources/annotation-dropdown-second-option-selected.pdf
    A LayoutTests/pdf/resources/annotation-two-radio-buttons-first-active.pdf
    A LayoutTests/pdf/resources/annotation-two-radio-buttons-second-active.pdf
    A LayoutTests/pdf/resources/go-back.html
    R LayoutTests/pdf/unifiedpdf/annotations/checkbox-set-active-expected.html
    R LayoutTests/pdf/unifiedpdf/annotations/checkbox-set-active.html
    R LayoutTests/pdf/unifiedpdf/annotations/dropdown-select-second-option-expected.html
    R LayoutTests/pdf/unifiedpdf/annotations/dropdown-select-second-option.html
    R LayoutTests/pdf/unifiedpdf/annotations/radio-buttons-select-second-expected.html
    R LayoutTests/pdf/unifiedpdf/annotations/radio-buttons-select-second.html
    R LayoutTests/pdf/unifiedpdf/images/jpeg2000-embed-pdf-expected.html
    R LayoutTests/pdf/unifiedpdf/images/jpeg2000-embed-pdf.html
    R LayoutTests/pdf/unifiedpdf/resources/400x400-green-jpeg2000.pdf
    R LayoutTests/pdf/unifiedpdf/resources/annotation-checkbox-active.pdf
    R LayoutTests/pdf/unifiedpdf/resources/annotation-checkbox-inactive.pdf
    R LayoutTests/pdf/unifiedpdf/resources/annotation-dropdown-first-option-selected.pdf
    R LayoutTests/pdf/unifiedpdf/resources/annotation-dropdown-second-option-selected.pdf
    R LayoutTests/pdf/unifiedpdf/resources/annotation-two-radio-buttons-first-active.pdf
    R LayoutTests/pdf/unifiedpdf/resources/annotation-two-radio-buttons-second-active.pdf
    M LayoutTests/platform/mac-site-isolation/TestExpectations
    M LayoutTests/platform/mac-ventura/TestExpectations
    M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  -----------
  282972 at main removed some valid PDF layout tests
https://bugs.webkit.org/show_bug.cgi?id=279224
rdar://135369479

Reviewed by Alex Christensen.

The NPAPI layout test cleanup in 282972 at main unintentionally removed
some functioning tests providing coverage for the PDF plugin.

This patch restores said tests, and takes the opportunity to consolidate
all relevant tests under `LayoutTests/pdf/`.

* LayoutTests/TestExpectations:
* LayoutTests/pdf/annotations/checkbox-set-active-expected.html: Renamed from LayoutTests/pdf/unifiedpdf/annotations/checkbox-set-active-expected.html.
* LayoutTests/pdf/annotations/checkbox-set-active.html: Renamed from LayoutTests/pdf/unifiedpdf/annotations/checkbox-set-active.html.
* LayoutTests/pdf/annotations/dropdown-select-second-option-expected.html: Renamed from LayoutTests/pdf/unifiedpdf/annotations/dropdown-select-second-option-expected.html.
* LayoutTests/pdf/annotations/dropdown-select-second-option.html: Renamed from LayoutTests/pdf/unifiedpdf/annotations/dropdown-select-second-option.html.
* LayoutTests/pdf/annotations/radio-buttons-select-second-expected.html: Renamed from LayoutTests/pdf/unifiedpdf/annotations/radio-buttons-select-second-expected.html.
* LayoutTests/pdf/annotations/radio-buttons-select-second.html: Renamed from LayoutTests/pdf/unifiedpdf/annotations/radio-buttons-select-second.html.
* LayoutTests/pdf/images/jpeg2000-embed-pdf-expected.html: Renamed from LayoutTests/pdf/unifiedpdf/images/jpeg2000-embed-pdf-expected.html.
* LayoutTests/pdf/images/jpeg2000-embed-pdf.html: Renamed from LayoutTests/pdf/unifiedpdf/images/jpeg2000-embed-pdf.html.
* LayoutTests/pdf/pdf-in-embed-expected.txt: Added.
* LayoutTests/pdf/pdf-in-embed-rounded-border-expected.html: Added.
* LayoutTests/pdf/pdf-in-embed-rounded-border.html: Added.
* LayoutTests/pdf/pdf-in-embed-with-root-page-zoom-expected.txt: Added.
* LayoutTests/pdf/pdf-in-embed-with-root-page-zoom.html: Added.
* LayoutTests/pdf/pdf-in-embed.html: Added.
* LayoutTests/pdf/pdf-in-iframe-scrolling-tree-after-back-expected.txt: Added.
* LayoutTests/pdf/pdf-in-iframe-scrolling-tree-after-back.html: Added.
* LayoutTests/pdf/pdf-in-styled-embed-expected.txt: Added.
* LayoutTests/pdf/pdf-in-styled-embed.html: Added.
* LayoutTests/pdf/pdf-plugin-hang-during-destruction-expected.txt: Added.
* LayoutTests/pdf/pdf-plugin-hang-during-destruction.html: Added.
* LayoutTests/pdf/pdf-plugin-null-onloaddeddata-expected.txt: Added.
* LayoutTests/pdf/pdf-plugin-null-onloaddeddata.html: Added.
* LayoutTests/pdf/pdf-plugin-printing-expected.txt: Added.
* LayoutTests/pdf/pdf-plugin-printing.html: Added.
* LayoutTests/pdf/pdf-scrolling-tree-dynamic-expected.txt: Added.
* LayoutTests/pdf/pdf-scrolling-tree-dynamic.html: Added.
* LayoutTests/pdf/pdf-scrolling-tree-expected.txt: Added.
* LayoutTests/pdf/pdf-scrolling-tree.html: Added.
* LayoutTests/pdf/resources/400x400-green-jpeg2000.pdf: Renamed from LayoutTests/pdf/unifiedpdf/resources/400x400-green-jpeg2000.pdf.
* LayoutTests/pdf/resources/annotation-checkbox-active.pdf: Renamed from LayoutTests/pdf/unifiedpdf/resources/annotation-checkbox-active.pdf.
* LayoutTests/pdf/resources/annotation-checkbox-inactive.pdf: Renamed from LayoutTests/pdf/unifiedpdf/resources/annotation-checkbox-inactive.pdf.
* LayoutTests/pdf/resources/annotation-dropdown-first-option-selected.pdf: Renamed from LayoutTests/pdf/unifiedpdf/resources/annotation-dropdown-first-option-selected.pdf.
* LayoutTests/pdf/resources/annotation-dropdown-second-option-selected.pdf: Renamed from LayoutTests/pdf/unifiedpdf/resources/annotation-dropdown-second-option-selected.pdf.
* LayoutTests/pdf/resources/annotation-two-radio-buttons-first-active.pdf: Renamed from LayoutTests/pdf/unifiedpdf/resources/annotation-two-radio-buttons-first-active.pdf.
* LayoutTests/pdf/resources/annotation-two-radio-buttons-second-active.pdf: Renamed from LayoutTests/pdf/unifiedpdf/resources/annotation-two-radio-buttons-second-active.pdf.
* LayoutTests/pdf/resources/go-back.html: Added.
* LayoutTests/platform/mac-site-isolation/TestExpectations:
* LayoutTests/platform/mac-ventura/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/283250@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications