[webkit-changes] [WebKit/WebKit] 46279b: [WebGPU] RenderBundleEncoder fails to replay comma...
mwyrzykowski
noreply at github.com
Thu Sep 5 19:38:01 PDT 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 46279b29a3cc4f8e0a63f2d526f02fae2fbb4fec
https://github.com/WebKit/WebKit/commit/46279b29a3cc4f8e0a63f2d526f02fae2fbb4fec
Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
Date: 2024-09-05 (Thu, 05 Sep 2024)
Changed paths:
A LayoutTests/fast/webgpu/nocrash/fuzz-279086-expected.txt
A LayoutTests/fast/webgpu/nocrash/fuzz-279086.html
M LayoutTests/platform/mac-wk2/TestExpectations
M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
Log Message:
-----------
[WebGPU] RenderBundleEncoder fails to replay commands on invalid encoder
https://bugs.webkit.org/show_bug.cgi?id=279086
rdar://135198220
Reviewed by Dan Glastonbury.
We were not handling OOM situations in the ICB path leading to incorrect
command encoding in OOM situations.
* LayoutTests/fast/webgpu/nocrash/fuzz-279086-expected.txt: Added.
* LayoutTests/fast/webgpu/nocrash/fuzz-279086.html: Added.
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::endCurrentICB):
* LayoutTests/TestExpectations
Test appears to crash outside of macOS Sequoia due to failed ICB allocation.
On macOS Sequoia the allocation fails gracefully which allows the test to
pass.
Canonical link: https://commits.webkit.org/283245@main
To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications
More information about the webkit-changes
mailing list