[webkit-changes] [WebKit/WebKit] 926b63: REGRESSION(276827 at main): Possible null pointer der...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 926b6385eb9ed88627005eb7713e042b00df5e2e
      https://github.com/WebKit/WebKit/commit/926b6385eb9ed88627005eb7713e042b00df5e2e
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2024-09-05 (Thu, 05 Sep 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/BitmapImageSource.cpp

  Log Message:
  -----------
  REGRESSION(276827 at main): Possible null pointer dereferencing when an image frame finishes decoding while the document is getting closed
https://bugs.webkit.org/show_bug.cgi?id=279221
rdar://133487516

Reviewed by Simon Fraser.

When the image decoding thread finishes decoding an image frame, don't cache
this frame unless the ImageDecoder is still available.

The callers of cacheMetadataAtIndex() and cacheNativeImageAtIndex() will ensure
the ImageDecoder is still available before calling these functions.

* Source/WebCore/platform/graphics/BitmapImageSource.cpp:
(WebCore::BitmapImageSource::imageFrameDecodeAtIndexHasFinished):
(WebCore::BitmapImageSource::cacheNativeImageAtIndex):

Canonical link: https://commits.webkit.org/283241@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications