[webkit-changes] [WebKit/WebKit] 03433c: [Writing Tools] During the rewrite animation, some...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 03433cf8ea044ee49d35adf47aa8dd9df8988490
      https://github.com/WebKit/WebKit/commit/03433cf8ea044ee49d35adf47aa8dd9df8988490
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2024-09-05 (Thu, 05 Sep 2024)

  Changed paths:
    M Source/WebCore/page/writing-tools/WritingToolsController.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm

  Log Message:
  -----------
  [Writing Tools] During the rewrite animation, some text temporarily is hidden and the animation looks broken
https://bugs.webkit.org/show_bug.cgi?id=279231
rdar://134991317

Reviewed by Aditya Keerthi.

Effectively revert 282750 at main, which ended up inadvertently adding transparent document markers to incorrect ranges.

Note that the bug that 282750 at main fixed still remains fixed, since 283109 at main inadvertently also fixes it by clearing
document markers after the animation finishes.

* Source/WebCore/page/writing-tools/WritingToolsController.mm:
(WebCore::WritingToolsController::compositionSessionDidReceiveTextWithReplacementRangeAsync):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:
(TEST(WritingTools, CompositionShowOriginalHasNoTransparentMarkers)):

Canonical link: https://commits.webkit.org/283238@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications