[webkit-changes] [WebKit/WebKit] 3725a9: [CSS Grid Layout] Fix grid-{row, column, area} sho...

[Zak Ridouh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3725a9f39e9d4973d8090c6dc135eafb69b81a76
      https://github.com/WebKit/WebKit/commit/3725a9f39e9d4973d8090c6dc135eafb69b81a76
  Author: Zak Ridouh <zakr at apple.com>
  Date:   2024-09-05 (Thu, 05 Sep 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-area-shorthand-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-area-valid-expected.txt
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/css/CSSGridLineNamesValue.cpp
    A Source/WebCore/css/CSSGridLineValue.cpp
    A Source/WebCore/css/CSSGridLineValue.h
    M Source/WebCore/css/CSSTimingFunctionValue.h
    M Source/WebCore/css/CSSValue.cpp
    M Source/WebCore/css/CSSValue.h
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  -----------
  [CSS Grid Layout] Fix grid-{row, column, area} shorthand CSSOM serialization
https://bugs.webkit.org/show_bug.cgi?id=149890
<rdar://132530604>

Reviewed by Matthieu Dubet.

Fix grid-area serialization, which previously was not fully following
the CSS Spec. Gains us a small amount on interop, and we are now passing
all tests in the grid-area-valid test[1].

This was done by adding a new child class of `CSSValue` called
`CSSGridLineValue`, and using it instead of `CSSValueList`, and
implementing the `customCSSText()` function in line with the spec.

[1] https://wpt.live/css/css-grid/parsing/grid-area-valid.html

    * LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-area-shorthand-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-area-valid-expected.txt:
    * Source/WebCore/Sources.txt:
    * Source/WebCore/WebCore.xcodeproj/project.pbxproj:
    * Source/WebCore/css/CSSGridLineNamesValue.cpp:
    * Source/WebCore/css/CSSGridLineValue.cpp: Added.
    (WebCore::CSSGridLineValue::customCSSText const):
    (WebCore::CSSGridLineValue::CSSGridLineValue):
    (WebCore::CSSGridLineValue::create):
    (WebCore::CSSGridLineValue::equals const):
    * Source/WebCore/css/CSSGridLineValue.h: Added.
    * Source/WebCore/css/CSSTimingFunctionValue.h:
    * Source/WebCore/css/CSSValue.cpp:
    (WebCore::CSSValue::visitDerived):
    * Source/WebCore/css/CSSValue.h:
    (WebCore::CSSValue::isGridLineValue const):
    * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
    (WebCore::CSSPropertyParserHelpers::consumeGridLine):
    * Source/WebCore/style/StyleBuilderConverter.h:
    (WebCore::Style::BuilderConverter::createGridPosition):

Canonical link: https://commits.webkit.org/283234@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications