[webkit-changes] [WebKit/WebKit] a4e454: [SVG2] Fix `presentational hints` special cases wh...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a4e4545085fa041626131f04be20cc284426e420
      https://github.com/WebKit/WebKit/commit/a4e4545085fa041626131f04be20cc284426e420
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-09-05 (Thu, 05 Sep 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/svg/styling/presentation-attributes-relevant-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/styling/presentation-attributes-special-cases-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/styling/presentation-attributes-special-cases.html
    M LayoutTests/imported/w3c/web-platform-tests/svg/styling/presentation-attributes.js
    M LayoutTests/platform/glib/svg/batik/text/textProperties-expected.txt
    M LayoutTests/platform/ios/svg/batik/text/textProperties-expected.txt
    M LayoutTests/platform/mac/svg/batik/text/textProperties-expected.txt
    M Source/WebCore/svg/SVGGElement.cpp
    M Source/WebCore/svg/SVGGElement.h
    M Source/WebCore/svg/SVGGradientElement.cpp
    M Source/WebCore/svg/SVGGradientElement.h
    M Source/WebCore/svg/SVGPatternElement.cpp
    M Source/WebCore/svg/SVGPatternElement.h

  Log Message:
  -----------
  [SVG2] Fix `presentational hints` special cases where supported

https://bugs.webkit.org/show_bug.cgi?id=279144
rdar://135298525

Reviewed by Simon Fraser.

This patch aligns WebKit with Gecko / Firefox, Blink / Chromium and
Web Specification [1]:

[1] https://svgwg.org/svg2-draft/styling.html#PresentationAttributes

This patch ensures that `gradientTransform`, `patternTransformAttribute`
and `transform` are mapped to transform property on supported elements.

This patch also sync particular test from WPT upstream as well.

Upstream commit: https://github.com/web-platform-tests/wpt/commit/3fed65b68731adff5b419980ad6c02bf83159252

* LayoutTests/imported/w3c/web-platform-tests/svg/styling/presentation-attributes-relevant-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/styling/presentation-attributes-special-cases-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/styling/presentation-attributes-special-cases.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/styling/presentation-attributes.js:
(presentationAttributeIsSupported):
* Source/WebCore/svg/SVGGElement.cpp:
(WebCore::SVGGElement::collectPresentationalHintsForAttribute):
* Source/WebCore/svg/SVGGElement.h:
* Source/WebCore/svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::collectPresentationalHintsForAttribute):
* Source/WebCore/svg/SVGGradientElement.h:
* Source/WebCore/svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::collectPresentationalHintsForAttribute):
* Source/WebCore/svg/SVGPatternElement.h:
* LayoutTests/platform/glib/svg/batik/text/textProperties-expected.txt:
* LayoutTests/platform/ios/svg/batik/text/textProperties-expected.txt:
* LayoutTests/platform/mac/svg/batik/text/textProperties-expected.txt:

Canonical link: https://commits.webkit.org/283223@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications