[webkit-changes] [WebKit/WebKit] 61868a: Blob url downloads fail when triggered from webext...

Commit Queue noreply at github.com
Thu Sep 5 10:36:20 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 61868ae02c5fa41a5e00c8d598eb06f388196b08
      https://github.com/WebKit/WebKit/commit/61868ae02c5fa41a5e00c8d598eb06f388196b08
  Author: Pascoe <pascoe at apple.com>
  Date:   2024-09-05 (Thu, 05 Sep 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/NavigationState.mm

  Log Message:
  -----------
  Blob url downloads fail when triggered from webextension
rdar://78929424
https://bugs.webkit.org/show_bug.cgi?id=226440

Reviewed by Timothy Hatcher.

Web Extensions can have anchor tags to blobs with download attributes
that are expected to download, but are prevented by isUnsupportedWebExtensionNavigation.

isUnsupportedWebExtensionNavigation is about preventing navigations away from extensions,
but downloads do not cause the page to navigate away. Therefore adding a case for downloads
here should be okay.

* Source/WebKit/UIProcess/Cocoa/NavigationState.mm:
(WebKit::isUnsupportedWebExtensionNavigation):

Canonical link: https://commits.webkit.org/283220@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list