[webkit-changes] [WebKit/WebKit] 3e4afc: text-decoration-thickness does not work in buttons...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3e4afc9d42442aa00f3d053a7ebea04eda1bd82a
      https://github.com/WebKit/WebKit/commit/3e4afc9d42442aa00f3d053a7ebea04eda1bd82a
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-09-05 (Thu, 05 Sep 2024)

  Changed paths:
    A LayoutTests/fast/inline/decorating-box-style-with-anon-block-container-expected.html
    A LayoutTests/fast/inline/decorating-box-style-with-anon-block-container.html
    M Source/WebCore/rendering/TextBoxPainter.cpp

  Log Message:
  -----------
  text-decoration-thickness does not work in buttons but works in div
https://bugs.webkit.org/show_bug.cgi?id=264245

Reviewed by Antti Koivisto.

While the spec says:

..decoration styles specified on a block container that establishes an inline
formatting context are propagated to an anonymous inline box that wraps all the in-flow
inline-level children of the block container...

we don't have the concept of such inline level box across generated anonymous block containers.

e.g.
<div non-inherited decoration style e.g. underline thickness>
 this text should be underlined
 <div></div>
 even when nested, inside anonymous block containers
</div>

* LayoutTests/fast/block/css-line-clamp-simple.html:
* LayoutTests/fast/inline/decorating-box-style-with-anon-block-container-expected.html: Added.
* LayoutTests/fast/inline/decorating-box-style-with-anon-block-container.html: Added.
* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::decoratingBoxStyleForRootInlineBox):
(WebCore::TextBoxPainter<TextBoxPath>::collectDecoratingBoxesForTextBox):

Canonical link: https://commits.webkit.org/283212@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications