[webkit-changes] [WebKit/WebKit] 9cfb6b: [Navigation] Provide better error reporting

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9cfb6bc898ed06e74bff228236d2405dbe3f67d9
      https://github.com/WebKit/WebKit/commit/9cfb6bc898ed06e74bff228236d2405dbe3f67d9
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2024-09-05 (Thu, 05 Sep 2024)

  Changed paths:
    M LayoutTests/http/wpt/navigation-api/transition-promises-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/signal-abort-window-stop-after-intercept-expected.txt
    M Source/WebCore/bindings/js/SerializedScriptValue.cpp
    M Source/WebCore/bindings/js/SerializedScriptValue.h
    M Source/WebCore/page/Navigation.cpp

  Log Message:
  -----------
  [Navigation] Provide better error reporting
https://bugs.webkit.org/show_bug.cgi?id=279032

Reviewed by Alex Christensen.

Provide better error reporting by refactoring code in SerializedScriptValue that extracts detailed
error information from JSC::ErrorInstance and reuse the new method both for error reporting when
aborting the navigation and on handler promise rejection.

* LayoutTests/http/wpt/navigation-api/transition-promises-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/signal-abort-window-stop-after-intercept-expected.txt:
* Source/WebCore/bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::extractErrorInformationFromErrorInstance):
* Source/WebCore/bindings/js/SerializedScriptValue.h:
* Source/WebCore/page/Navigation.cpp:
(WebCore::Navigation::abortOngoingNavigation):
(WebCore::Navigation::innerDispatchNavigateEvent):

Canonical link: https://commits.webkit.org/283197@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications