[webkit-changes] [WebKit/WebKit] 1b1f02: [WebGPU] Instance being retained longer than its c...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1b1f0299a6918f7ab386fee8d5f442913385cc85
      https://github.com/WebKit/WebKit/commit/1b1f0299a6918f7ab386fee8d5f442913385cc85
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-09-04 (Wed, 04 Sep 2024)

  Changed paths:
    M Source/WebGPU/WebGPU/Adapter.h
    M Source/WebGPU/WebGPU/Adapter.mm
    M Source/WebGPU/WebGPU/BindGroup.mm
    M Source/WebGPU/WebGPU/ComputePipeline.mm
    M Source/WebGPU/WebGPU/Device.h
    M Source/WebGPU/WebGPU/Device.mm
    M Source/WebGPU/WebGPU/ExternalTexture.mm
    M Source/WebGPU/WebGPU/Instance.h
    M Source/WebGPU/WebGPU/Queue.mm
    M Source/WebGPU/WebGPU/RenderPipeline.mm

  Log Message:
  -----------
  [WebGPU] Instance being retained longer than its corresponding RemoteGPU
https://bugs.webkit.org/show_bug.cgi?id=279138
rdar://135292412

Reviewed by Dan Glastonbury.

Chance Instance from Ref<> to a ThreadSafeWeakPtr<> to break a retain
cycle causing Instance to outlive it's corresponding RemoteGPU instance.

* Source/WebGPU/WebGPU/Adapter.h:
(WebGPU::Adapter::instance const):
* Source/WebGPU/WebGPU/Adapter.mm:
(WebGPU::Adapter::Adapter):
* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::Device::createExternalTextureFromPixelBuffer const):
* Source/WebGPU/WebGPU/Device.h:
(WebGPU::Device::instance const):
* Source/WebGPU/WebGPU/Device.mm:
(WebGPU::Device::Device):
(WebGPU::Device::setOwnerWithIdentity const):
(WebGPU::Device::popErrorScope):
(WebGPU::Device::webProcessID const):
* Source/WebGPU/WebGPU/ExternalTexture.mm:
(WebGPU::ExternalTexture::update):
* Source/WebGPU/WebGPU/Instance.h:
* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::scheduleWork):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::createRenderPipelineAsync):

Canonical link: https://commits.webkit.org/283190@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications