[webkit-changes] [WebKit/WebKit] bec6d2: Web Inspector: $event ReferenceError in Safari ext...

[Devin Rousso]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bec6d22a93435031499a6631639a841c3c438860
      https://github.com/WebKit/WebKit/commit/bec6d22a93435031499a6631639a841c3c438860
  Author: Devin Rousso <hi at devinrousso.com>
  Date:   2024-09-04 (Wed, 04 Sep 2024)

  Changed paths:
    A LayoutTests/inspector/dom-debugger/command-line-api-event-expected.txt
    A LayoutTests/inspector/dom-debugger/command-line-api-event.html
    M Source/WebCore/inspector/agents/InspectorDOMDebuggerAgent.cpp

  Log Message:
  -----------
  Web Inspector: $event ReferenceError in Safari extension event listeners
https://bugs.webkit.org/show_bug.cgi?id=278919

Reviewed by BJ Burg.

Grabbing the `GlobalObject` from the `ScriptExecutionContext` is not always going to be correct if the `EventListener` was created in a `DOMWrapperWorld`.

* Source/WebCore/inspector/agents/InspectorDOMDebuggerAgent.cpp:
(WebCore::globalObject): Added.
(WebCore::InspectorDOMDebuggerAgent::willHandleEvent):
(WebCore::InspectorDOMDebuggerAgent::didHandleEvent):

* LayoutTests/inspector/dom-debugger/command-line-api-event.html: Added.
* LayoutTests/inspector/dom-debugger/command-line-api-event-expected.txt: Added.

Canonical link: https://commits.webkit.org/283181@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications