[webkit-changes] [WebKit/WebKit] 70c0d8: run-webkit-tests --print-expectations -v lists all...

[Gerald Squelart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 70c0d8553e42c0cb5209bab2b8ffd6f813e42d0c
      https://github.com/WebKit/WebKit/commit/70c0d8553e42c0cb5209bab2b8ffd6f813e42d0c
  Author: Gerald Squelart <g_squelart at apple.com>
  Date:   2024-09-04 (Wed, 04 Sep 2024)

  Changed paths:
    M Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
    M Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py
    M Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
    M Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py
    M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

  Log Message:
  -----------
  run-webkit-tests --print-expectations -v lists all considered TextExpectations lines
https://bugs.webkit.org/show_bug.cgi?id=269895
rdar://123424189

Reviewed by Sam Sneddon.

Instead of only showing the one line that was used to set a test's expectations,
we can now show all the lines that were also considered before and/or after.

A unit test was added to verify that the non-verbose output matches exactly with
the expected output, to avoid issues with buildbots that crudely diff this
output between revisions.

* Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._print_expectation_line_for_test):
(Manager._print_expectations_for_subset):
* Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest._get_manager):
(ManagerTest.test_look_for_new_crash_logs):
(ManagerTest):
(ManagerTest.test_print_expectations_for_subset):
(ManagerTest.test_print_expectations_for_subset.get_test_names):
(ManagerTest.test_print_expectations_for_subset.get_tests):
(ManagerTest.test_print_expectations_for_subset.get_expectations):
(get_printed_expectations):
(parse_exp):
(ManagerTest.test_look_for_new_crash_logs.get_manager): Deleted.
* Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationsModel.__init__):
(TestExpectationsModel.get_expectation_lines):
(TestExpectationsModel.add_expectation_line):
* Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
* Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):

Canonical link: https://commits.webkit.org/283176@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications