[webkit-changes] [WebKit/WebKit] 0d018b: Fix ARMv7 clang build

Justin Michaud noreply at github.com
Wed Sep 4 14:19:54 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0d018b90f3748e5cb86e937bd7708015899217ae
      https://github.com/WebKit/WebKit/commit/0d018b90f3748e5cb86e937bd7708015899217ae
  Author: Justin Michaud <jmichaud at igalia.com>
  Date:   2024-09-04 (Wed, 04 Sep 2024)

  Changed paths:
    M Source/JavaScriptCore/wasm/WasmBBQJIT32_64.cpp
    M Source/WTF/wtf/Compiler.h

  Log Message:
  -----------
  Fix ARMv7 clang build
https://bugs.webkit.org/show_bug.cgi?id=279039

Reviewed by Yusuke Suzuki.

This works around some issues with the build when
using clang.

Re: tail calls, I am not sure if it is a clang bug
or if there is some other reason why it is failing
to make MUST_TAIL_CALL return JSRopeString::resolveToBufferSlow
a tail call, but it seems safe to disable it for now.

* Source/JavaScriptCore/wasm/WasmBBQJIT32_64.cpp:
(JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDLoad):
(JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDStore):
(JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDSplat):
(JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDShuffle):
(JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDShift):
(JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDExtmul):
(JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDLoadSplat):
(JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDLoadLane):
(JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDStoreLane):
(JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDLoadExtend):
(JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDLoadPad):
(JSC::Wasm::BBQJITImpl::BBQJIT::addConstant):
(JSC::Wasm::BBQJITImpl::BBQJIT::addExtractLane):
(JSC::Wasm::BBQJITImpl::BBQJIT::addReplaceLane):
(JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDI_V):
(JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDV_V):
(JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDBitwiseSelect):
(JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDRelOp):
(JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDV_VV):
(JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDRelaxedFMA):
* Source/WTF/wtf/Compiler.h:

Canonical link: https://commits.webkit.org/283173@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list