[webkit-changes] [WebKit/WebKit] b9f177: [WebDriver][WPE] Segfault in MiniBrowser in some t...

Lauro Moura noreply at github.com
Wed Sep 4 13:35:25 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b9f177ccdf00a6ea7e5983939ec470063dd6d3e2
      https://github.com/WebKit/WebKit/commit/b9f177ccdf00a6ea7e5983939ec470063dd6d3e2
  Author: Lauro Moura <lmoura at igalia.com>
  Date:   2024-09-04 (Wed, 04 Sep 2024)

  Changed paths:
    M Tools/MiniBrowser/wpe/main.cpp

  Log Message:
  -----------
  [WebDriver][WPE] Segfault in MiniBrowser in some tests when the first window is closed and a new one is created
https://bugs.webkit.org/show_bug.cgi?id=279101

Reviewed by Carlos Garcia Campos.

Ensure we're using a live view as the base for new automated views. And
in the case of the old WPE API, ensure we're returning a live view.

This fixes the case where the original view might have been closed and
the application is kept alive through younger views.

In a future commit, we might avoid hardcoding the original view as the
createWebViewForAutomationCallback user data, using another scheme to
track a live view.

* Tools/MiniBrowser/wpe/main.cpp:
(createWebViewForAutomationCallback):

Canonical link: https://commits.webkit.org/283170@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list