[webkit-changes] [WebKit/WebKit] c58919: CSS view timeline needs conversion data to properl...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c58919c8dc38fa050a4a1e4396c203a264881e52
      https://github.com/WebKit/WebKit/commit/c58919c8dc38fa050a4a1e4396c203a264881e52
  Author: Sam Weinig <sam at webkit.org>
  Date:   2024-09-04 (Wed, 04 Sep 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-computed.html
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-parsing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-parsing.html
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    A Source/WebCore/animation/ScrollAxis.cpp
    M Source/WebCore/animation/ScrollAxis.h
    M Source/WebCore/animation/ScrollTimeline.cpp
    M Source/WebCore/animation/ScrollTimeline.h
    M Source/WebCore/animation/ViewTimeline.cpp
    M Source/WebCore/animation/ViewTimeline.h
    M Source/WebCore/css/CSSToStyleMap.cpp
    M Source/WebCore/css/CSSToStyleMap.h
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/parser/CSSPropertyParser.cpp
    A Source/WebCore/css/parser/CSSPropertyParserConsumer+Timeline.cpp
    A Source/WebCore/css/parser/CSSPropertyParserConsumer+Timeline.h
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
    M Source/WebCore/css/process-css-properties.py
    M Source/WebCore/platform/animation/Animation.cpp
    M Source/WebCore/platform/animation/Animation.h

  Log Message:
  -----------
  CSS view timeline needs conversion data to properly resolve insets
https://bugs.webkit.org/show_bug.cgi?id=279097

Reviewed by Tim Nguyen.

Removes use of deprecated primitive value resolvers by passing in
conversion data for resolution.

With resolution now potentially creating Calculation::Values, computed
value support needs to pipe the RenderStyle in so that the primitive
value can be correctly constructed.

Takes opportunity to split timeline specific parsing into its own
set of files.

* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-computed.html:
* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-parsing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-parsing.html:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/ScrollAxis.cpp: Added.
* Source/WebCore/animation/ScrollAxis.h:
* Source/WebCore/animation/ScrollTimeline.cpp:
* Source/WebCore/animation/ScrollTimeline.h:
* Source/WebCore/animation/ViewTimeline.cpp:
* Source/WebCore/animation/ViewTimeline.h:
* Source/WebCore/css/CSSToStyleMap.cpp:
* Source/WebCore/css/CSSToStyleMap.h:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Timeline.cpp: Added.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Timeline.h: Added.
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebCore/css/process-css-properties.py:
* Source/WebCore/platform/animation/Animation.cpp:
* Source/WebCore/platform/animation/Animation.h:

Canonical link: https://commits.webkit.org/283155@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications