[webkit-changes] [WebKit/WebKit] 6136b6: [IFC] Incorrect vertical position of nested conten...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6136b6004d41918704413f7f35cd6d4a650e9a46
      https://github.com/WebKit/WebKit/commit/6136b6004d41918704413f7f35cd6d4a650e9a46
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-09-04 (Wed, 04 Sep 2024)

  Changed paths:
    A LayoutTests/fast/inline/nested-vertical-alignment-with-bottom-and-line-height-expected.html
    A LayoutTests/fast/inline/nested-vertical-alignment-with-bottom-and-line-height.html
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.h

  Log Message:
  -----------
  [IFC] Incorrect vertical position of nested content with parent of 'vertical-align: bottom'
https://bugs.webkit.org/show_bug.cgi?id=279091

Reviewed by Antti Koivisto.

Certain align values can pull nested content upward producing negative descent values.
This patch makes sure we don't treat 0 as a minimum for ascent/descent.

* LayoutTests/fast/inline/nested-vertical-alignment-with-bottom-and-line-height-expected.html: Added.
* LayoutTests/fast/inline/nested-vertical-alignment-with-bottom-and-line-height.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp:
(WebCore::Layout::LineBoxVerticalAligner::layoutBoundsForInlineBoxSubtree const):
(WebCore::Layout::LineBoxVerticalAligner::alignInlineLevelBoxes const):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.h:

Canonical link: https://commits.webkit.org/283153@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications