[webkit-changes] [WebKit/WebKit] 667de7: [GStreamer][MediaStream] Reduce usage of the playe...

Philippe Normand noreply at github.com
Wed Sep 4 02:26:11 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 667de7f8240d80a7c83b76a4265619733ee40d20
      https://github.com/WebKit/WebKit/commit/667de7f8240d80a7c83b76a4265619733ee40d20
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-09-04 (Wed, 04 Sep 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

  Log Message:
  -----------
  [GStreamer][MediaStream] Reduce usage of the player's m_isPaused variable
https://bugs.webkit.org/show_bug.cgi?id=278983

Reviewed by Xabier Rodriguez-Calvar.

Use the paused() method to know if the newly added audio track should start or not. The m_isPaused
variable is confusing, see also bug #260385.

Covered by fast/mediastream/play-newly-added-audio-track.html

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::paused const):
(WebCore::MediaPlayerPrivateGStreamer::configureMediaStreamAudioTracks):
(WebCore::MediaPlayerPrivateGStreamer::updateStates):

Canonical link: https://commits.webkit.org/283144@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list