[webkit-changes] [WebKit/WebKit] 960090: [IFC][Cleanup] Move "logical top offset from basel...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 960090f6f6264b7fb8c288e3ea76b7160d248ede
      https://github.com/WebKit/WebKit/commit/960090f6f6264b7fb8c288e3ea76b7160d248ede
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-09-03 (Tue, 03 Sep 2024)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.h

  Log Message:
  -----------
  [IFC][Cleanup] Move "logical top offset from baseline" computation to a dedicated function
https://bugs.webkit.org/show_bug.cgi?id=279068

Reviewed by Antti Koivisto.

This is in preparation for fixing webkit.org/b/279034.

"logical top offset from baseline" is used by computeLineBoxLogicalHeight, computeRootInlineBoxVerticalPosition and alignInlineLevelBoxes.

* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp:
(WebCore::Layout::LineBoxVerticalAligner::logicalTopOffsetFromParentBaseline const):
(WebCore::Layout::LineBoxVerticalAligner::computeLineBoxLogicalHeight const):
(WebCore::Layout::LineBoxVerticalAligner::computeRootInlineBoxVerticalPosition const):
(WebCore::Layout::LineBoxVerticalAligner::alignInlineLevelBoxes const):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.h:

Canonical link: https://commits.webkit.org/283117@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications