[webkit-changes] [WebKit/WebKit] 633f43: [IFC][Cleanup] Unify inline-level box top position...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 633f43928a377d70395964507c393abf4de13078
      https://github.com/WebKit/WebKit/commit/633f43928a377d70395964507c393abf4de13078
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-09-03 (Tue, 03 Sep 2024)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp

  Log Message:
  -----------
  [IFC][Cleanup] Unify inline-level box top position/baseline offset computation in LineBoxVerticalAligner
https://bugs.webkit.org/show_bug.cgi?id=279062

Reviewed by Antti Koivisto.

This is in preparation for fixing webkit.org/b/279034.

1. compute 'topOffsetFromParentBaseline' values for each vertical align value
2. use 'topOffsetFromParentBaseline' to compute the top position/baseline offset

* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp:
(WebCore::Layout::LineBoxVerticalAligner::computeLineBoxLogicalHeight const):
(WebCore::Layout::LineBoxVerticalAligner::computeRootInlineBoxVerticalPosition const):
(WebCore::Layout::LineBoxVerticalAligner::alignInlineLevelBoxes const):

Canonical link: https://commits.webkit.org/283114@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications