[webkit-changes] [WebKit/WebKit] 307823: _WKDownload client should be able to publish progress

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 307823d4b18290a30bd50e763949a145135140dd
      https://github.com/WebKit/WebKit/commit/307823d4b18290a30bd50e763949a145135140dd
  Author: Per Arne Vollan <pvollan at apple.com>
  Date:   2024-09-03 (Tue, 03 Sep 2024)

  Changed paths:
    M Source/WebKit/NetworkProcess/NetworkProcess.messages.in
    M Source/WebKit/UIProcess/API/Cocoa/_WKDownload.mm
    M Source/WebKit/UIProcess/Downloads/DownloadProxy.h
    M Source/WebKit/UIProcess/Downloads/DownloadProxyCocoa.mm

  Log Message:
  -----------
  _WKDownload client should be able to publish progress
https://bugs.webkit.org/show_bug.cgi?id=278997
rdar://135116654

Reviewed by Brady Eidson.

_WKDownload clients should be able to publish progress for a specific URL. The commit
https://commits.webkit.org/283043@main removed this ability, since progress publishing
will be handled by WebKit and not the client when MODERN_DOWNLOADPROGRESS is enabled.
The code is being compiled in for this feature, but the feature is currently disabled
by a runtime check. This means it is too early to remove this capability for
_WKDownload clients. We can remove this capability once rdar://125569813 has landed.
This patch is essentially reverting a small part of 283043 at main.

* Source/WebKit/NetworkProcess/NetworkProcess.messages.in:
* Source/WebKit/UIProcess/API/Cocoa/_WKDownload.mm:
(-[_WKDownload publishProgressAtURL:]):
* Source/WebKit/UIProcess/Downloads/DownloadProxy.h:
* Source/WebKit/UIProcess/Downloads/DownloadProxyCocoa.mm:
(WebKit::DownloadProxy::publishProgress):

Canonical link: https://commits.webkit.org/283110@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications