[webkit-changes] [WebKit/WebKit] 7f45cb: Transitioning Unregistered Custom Properties cause...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7f45cbdcfbf577be7af7983df00fb20a55d918d6
      https://github.com/WebKit/WebKit/commit/7f45cbdcfbf577be7af7983df00fb20a55d918d6
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-09-03 (Tue, 03 Sep 2024)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/custom-property-and-allow-discrete-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/custom-property-and-allow-discrete.html
    M Source/WebCore/animation/CSSPropertyAnimation.cpp

  Log Message:
  -----------
  Transitioning Unregistered Custom Properties cause a transition loop
https://bugs.webkit.org/show_bug.cgi?id=279012

Reviewed by Antti Koivisto.

There is no need to have special logic in `CSSPropertyAnimation::propertiesEqual()` to deal with the
various value variants held by `CSSCustomPropertyValue` since `CSSCustomPropertyValue::equals()`
already checks the two values have the same type and then performs the equality check. This will allow
variant types not previously explicitly tested by `CSSPropertyAnimation::propertiesEqual()` to be tested,
such as unregistered properties that have no explicit value type.

* LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/custom-property-and-allow-discrete-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/custom-property-and-allow-discrete.html: Added.
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimation::propertiesEqual):

Canonical link: https://commits.webkit.org/283099@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications