[webkit-changes] [WebKit/WebKit] 384574: [WebGPU] id<MTLSamplerState> is retained unnecessa...

mwyrzykowski noreply at github.com
Tue Sep 3 08:19:52 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3845740eb3e24283fc43ea8786240c453c24e4be
      https://github.com/WebKit/WebKit/commit/3845740eb3e24283fc43ea8786240c453c24e4be
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-09-03 (Tue, 03 Sep 2024)

  Changed paths:
    M Source/WebGPU/WebGPU/Sampler.h
    M Source/WebGPU/WebGPU/Sampler.mm

  Log Message:
  -----------
  [WebGPU] id<MTLSamplerState> is retained unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=278972
<radar://135086198>

Reviewed by Dan Glastonbury.

The sampler cache was holding on to the sampler when it did not need to.

Also fix race which could occur when two WebGPU work queues tried to
create a sampler at the same time.

* Source/WebGPU/WebGPU/Sampler.h:
* Source/WebGPU/WebGPU/Sampler.mm:
(WebGPU::Sampler::~Sampler):
(WebGPU::Sampler::samplerState const):

Canonical link: https://commits.webkit.org/283095@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list