[webkit-changes] [WebKit/WebKit] ef0886: Cherry-pick 282982 at main (e79f0fb6daa6). https://bu...

[bnham]

  Branch: refs/heads/webkitglib/2.46
  Home:   https://github.com/WebKit/WebKit
  Commit: ef08869f0f15c8d33e7e24d546d00553f7d624a1
      https://github.com/WebKit/WebKit/commit/ef08869f0f15c8d33e7e24d546d00553f7d624a1
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2024-09-03 (Tue, 03 Sep 2024)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp

  Log Message:
  -----------
  Cherry-pick 282982 at main (e79f0fb6daa6). https://bugs.webkit.org/show_bug.cgi?id=271050

    [GStreamer][Debug] http/tests/navigation/page-cache-video.html asserts
    https://bugs.webkit.org/show_bug.cgi?id=271050

    Reviewed by Alicia Boya Garcia.

    The assertion doesn't cover seamless looping [1].

    [1] https://gstreamer.freedesktop.org/documentation/additional/design/seeking.html?gi-language=c#segment-seeking-without-flush

    * LayoutTests/platform/glib/TestExpectations:
    * Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
    (webKitWebSrcDoSeek):

    Canonical link: https://commits.webkit.org/282982@main

Canonical link: https://commits.webkit.org/282416.45@webkitglib/2.46


  Commit: 325f39df60ad6ca09db6f91c1536c3a15f11d43b
      https://github.com/WebKit/WebKit/commit/325f39df60ad6ca09db6f91c1536c3a15f11d43b
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2024-09-03 (Tue, 03 Sep 2024)

  Changed paths:
    M Source/WebCore/xml/XPathNodeSet.cpp

  Log Message:
  -----------
  Cherry-pick 282992 at main (7ce6a1c447e1). https://bugs.webkit.org/show_bug.cgi?id=278781

    Some `fast/xpath` tests hit an assertion in release with `ENABLE_ASSERTS=1`
    https://bugs.webkit.org/show_bug.cgi?id=278781

    Reviewed by Alexey Proskuryakov.

    In https://github.com/WebKit/WebKit/pull/32818 @aproskuryakov rightly
    noted that "when someone builds with ENABLE_ASSERTS=1, they presumably
    want the asserts to work, not to be ifdefed out".

    * Source/WebCore/xml/XPathNodeSet.cpp:
    (WebCore::XPath::sortBlock):

    Canonical link: https://commits.webkit.org/282992@main

Canonical link: https://commits.webkit.org/282416.46@webkitglib/2.46


  Commit: c52dad45e1cfd2de7a7d59d82704f235389daa24
      https://github.com/WebKit/WebKit/commit/c52dad45e1cfd2de7a7d59d82704f235389daa24
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2024-09-03 (Tue, 03 Sep 2024)

  Changed paths:
    M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp

  Log Message:
  -----------
  Cherry-pick 282911 at main (55a33a45250a). https://bugs.webkit.org/show_bug.cgi?id=278854

    REGRESSION(281966 at main): The URL passed to `WebPageProxy::maybeInitializeSandboxExtensionHandle` is null
    https://bugs.webkit.org/show_bug.cgi?id=278854

    Reviewed by Chris Dumez.

    In `ProvisionalPageProxy::goToBackForwardItem()` we create an `itemURL`
    which we then pass by reference to `WebPageProxy::maybeInitializeSandboxExtensionHandle()`.
    But we also move it while creating the compilation handler, which makes it null.
    We should just make a copy.

    * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
    (WebKit::ProvisionalPageProxy::goToBackForwardItem):

    Canonical link: https://commits.webkit.org/282911@main

Canonical link: https://commits.webkit.org/282416.47@webkitglib/2.46


  Commit: e1c6843e93f6ce3dd79b4133ac072cd373d28b0b
      https://github.com/WebKit/WebKit/commit/e1c6843e93f6ce3dd79b4133ac072cd373d28b0b
  Author: Georges Basile Stavracas Neto <feaneron at igalia.com>
  Date:   2024-09-03 (Tue, 03 Sep 2024)

  Changed paths:
    M Source/WTF/wtf/SystemTracing.h
    M Source/WTF/wtf/glib/SysprofAnnotator.h
    M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
    M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp
    M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  -----------
  Cherry-pick 282779 at main (f6853da27ea8). https://bugs.webkit.org/show_bug.cgi?id=278411

    [GLIB] Add more signpost marks related to graphics
    https://bugs.webkit.org/show_bug.cgi?id=278411

    Reviewed by Nikolas Zimmermann.

    Add a series of marks that act as submarks of BackingStoreFlush. In
    particular, the important ones are the marks tile renders.

    * Source/WTF/wtf/SystemTracing.h:
    * Source/WTF/wtf/glib/SysprofAnnotator.h:
    * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
    (WebCore::CoordinatedGraphicsLayer::updateContentBuffers):
    * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp:
    (WebCore::CoordinatedGraphicsLayer::paintTile):
    * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
    (WebKit::CompositingCoordinator::flushPendingLayerChanges):
    * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:
    (WebKit::LayerTreeHost::commitSceneState):
    * Source/WebKit/WebProcess/WebPage/WebPage.cpp:
    (WebKit::WebPage::finalizeRenderingUpdate):

    Canonical link: https://commits.webkit.org/282779@main

Canonical link: https://commits.webkit.org/282416.48@webkitglib/2.46


  Commit: 8722cfa0c4328ba3acb7fc5f46abbb3ca07c7d37
      https://github.com/WebKit/WebKit/commit/8722cfa0c4328ba3acb7fc5f46abbb3ca07c7d37
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2024-09-03 (Tue, 03 Sep 2024)

  Changed paths:
    M Source/WTF/wtf/SystemTracing.h

  Log Message:
  -----------
  Cherry-pick 282790 at main (1d38892f5070). https://bugs.webkit.org/show_bug.cgi?id=278730

    REGRESSION(282779 at main) Broke Apple Internal builds
    https://bugs.webkit.org/show_bug.cgi?id=278730
    rdar://134780683

    Unreviewed internal build fix.

    * Source/WTF/wtf/SystemTracing.h: Add FinalizeRenderingUpdate signpost.

    Canonical link: https://commits.webkit.org/282790@main

Canonical link: https://commits.webkit.org/282416.49@webkitglib/2.46


  Commit: 11ee713f38e98423959d779c87ad741af4736946
      https://github.com/WebKit/WebKit/commit/11ee713f38e98423959d779c87ad741af4736946
  Author: Ben Nham <nham at apple.com>
  Date:   2024-09-03 (Tue, 03 Sep 2024)

  Changed paths:
    M Source/WTF/wtf/SystemTracing.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  -----------
  Cherry-pick 282803 at main (a253e130f304). https://bugs.webkit.org/show_bug.cgi?id=278732

    Fix build break from 282779 at main
    https://bugs.webkit.org/show_bug.cgi?id=278732
    rdar://134784868

    Reviewed by Wenson Hsieh.

    282779 at main broke the Cocoa build. We did not catch this on the bots because SystemTracing.h
    conditionalized calls to `os_signpost` based on `HAVE(KDEBUG_H)` rather than `HAVE(OS_SIGNPOST)`.

    Fixed these issues:

    1. All signpost names passed to WTF signpost macros on Cocoa must also be part of the
    FOR_EACH_WTF_SIGNPOST_NAME list in the header. 282779 at main added the FinalizeRenderingUpdate
    signpost on Cocoa, but it wasn't part of the header.
    2. Always build the os_signpost code on Cocoa so we catch build breaks like this in the future.
    3. Simon says he doesn't want the FinalizeRenderingUpdate signpost on Cocoa, so conditionalize that
    call.

    * Source/WebKit/WebProcess/WebPage/WebPage.cpp:
    (WebKit::WebPage::finalizeRenderingUpdate):

    Canonical link: https://commits.webkit.org/282803@main

Canonical link: https://commits.webkit.org/282416.50@webkitglib/2.46


Compare: https://github.com/WebKit/WebKit/compare/b9e562a8ac6c...11ee713f38e9

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications