[webkit-changes] [WebKit/WebKit] a3f7d7: Cherry-pick 282924 at main (c3079fe52eeb). https://bu...

[Wenson Hsieh]

  Branch: refs/heads/webkitglib/2.46
  Home:   https://github.com/WebKit/WebKit
  Commit: a3f7d73e77888e28a1f409ac7ee2a29936360ffb
      https://github.com/WebKit/WebKit/commit/a3f7d73e77888e28a1f409ac7ee2a29936360ffb
  Author: Alexsander Borges Damaceno <alexbdamac at gmail.com>
  Date:   2024-09-03 (Tue, 03 Sep 2024)

  Changed paths:
    M Source/WebCore/dom/ImageOverlay.cpp

  Log Message:
  -----------
  Cherry-pick 282924 at main (c3079fe52eeb). https://bugs.webkit.org/show_bug.cgi?id=278843

    Deploy more smart pointers in ImageOverlay.cpp
    https://bugs.webkit.org/show_bug.cgi?id=278843

    Reviewed by Ryosuke Niwa.

    Deploy more smart pointers in ImageOverlay.cpp

    * Source/WebCore/dom/ImageOverlay.cpp:
    (WebCore::ImageOverlay::updateSubtree):

    Canonical link: https://commits.webkit.org/282924@main

Canonical link: https://commits.webkit.org/282416.43@webkitglib/2.46


  Commit: b9e562a8ac6cb1b5738319c75a84660c65c562be
      https://github.com/WebKit/WebKit/commit/b9e562a8ac6cb1b5738319c75a84660c65c562be
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-09-03 (Tue, 03 Sep 2024)

  Changed paths:
    M Source/WebCore/dom/ImageOverlay.cpp

  Log Message:
  -----------
  Cherry-pick 283030 at main (416adec17dd1). https://bugs.webkit.org/show_bug.cgi?id=252302

    REGRESSION (253225 at main): ASSERT_NOT_REACHED in ImageOverlay updateSubtree()
    https://bugs.webkit.org/show_bug.cgi?id=252302
    rdar://105486027

    Reviewed by Richard Robinson.

    After the changes in https://commits.webkit.org/253225@main, installing the user agent shadow root
    on `HTMLMediaElement` no longer ensures that media controls host elements are also created. As such,
    the debug assertions which try to verify that the media controls host and controls container `div`
    have been created fail, and we crash when installing Live Text in a `video` with no controls.

    The intention behind this logic is to determine whether Live Text should be injected underneath the
    user agent shadow root or under the media controls container in the user agent shadow root, so that
    Live Text doesn't overlap the fullscreen/PiP buttons or the slider (and the controls around it).
    However, it's actually not necessary in this case to create and add media controls up front, since
    we'll (correctly) add the media controls _over_ the image overlay anyways, in the case where the
    controls haven't been created yet. If the controls _have_ already been created, then we should get a
    non-null `mediaControlsContainer`.

    Address this debug assert by checking if the media controls container `div` had already been created
    without ensuring the user agent shadow root up front in `updateSubtree`.

    This fixes several flaky layout tests in `media/modern-media-controls/tracks-support`.

    * Source/WebCore/dom/ImageOverlay.cpp:
    (WebCore::ImageOverlay::updateSubtree):

    Canonical link: https://commits.webkit.org/283030@main

Canonical link: https://commits.webkit.org/282416.44@webkitglib/2.46


Compare: https://github.com/WebKit/WebKit/compare/cdf8f11cd1d8...b9e562a8ac6c

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications