[webkit-changes] [WebKit/WebKit] 051d63: Fix select.add() with optgroups

Anne van Kesteren noreply at github.com
Mon Sep 2 22:10:46 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 051d6305c9d99f7db2fe6151ebc2c7dd22e32e43
      https://github.com/WebKit/WebKit/commit/051d6305c9d99f7db2fe6151ebc2c7dd22e32e43
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2024-09-02 (Mon, 02 Sep 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/select-add-optgroup-expected.txt
    M Source/WebCore/html/HTMLSelectElement.cpp

  Log Message:
  -----------
  Fix select.add() with optgroups
https://bugs.webkit.org/show_bug.cgi?id=266935
rdar://120553757

Reviewed by Chris Dumez.

Implement missing aspects from
https://html.spec.whatwg.org/multipage/common-dom-interfaces.html#dom-htmloptionscollection-add

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/select-add-optgroup-expected.txt:
* Source/WebCore/html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::add):

Canonical link: https://commits.webkit.org/283080@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list