[webkit-changes] [WebKit/WebKit] 6d7805: [view-transitions] Toggling a skew transform cause...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6d78055bf6abba05dba6cad35c9899104c3ec15d
      https://github.com/WebKit/WebKit/commit/6d78055bf6abba05dba6cad35c9899104c3ec15d
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-09-02 (Mon, 02 Sep 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-interpolation-005-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-interpolation-005.html
    M Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp

  Log Message:
  -----------
  [view-transitions] Toggling a skew transform causes a position shift.
https://bugs.webkit.org/show_bug.cgi?id=277988
<rdar://133721607>

Reviewed by Dan Glastonbury.

recompose2 was applying the translate component to the wrong side of the
transform. Fix this, and stop using the 3d variant.

This bug is long standing, but mostly only affected computed style, as we use
CoreAnimation to interpolate values for actual rendering.

ViewTransition forces the rendering interpolation to happen using the WebKit
code, so it became a rendering bug too.

* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-interpolation-005-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-interpolation-005.html:
* Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::recompose2):

Canonical link: https://commits.webkit.org/283072@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications