[webkit-changes] [WebKit/WebKit] 800fec: CSS -webkit-cross-fade function should not eagerly...

Commit Queue noreply at github.com
Mon Sep 2 13:23:16 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 800fec67b75a7763bf9692916eb2411a885ade04
      https://github.com/WebKit/WebKit/commit/800fec67b75a7763bf9692916eb2411a885ade04
  Author: Sam Weinig <sam at webkit.org>
  Date:   2024-09-02 (Mon, 02 Sep 2024)

  Changed paths:
    M LayoutTests/fast/css/getComputedStyle/computed-style-cross-fade-expected.txt
    M LayoutTests/fast/css/getComputedStyle/computed-style-cross-fade.html
    A LayoutTests/fast/images/valid-style-cross-fade-expected.txt
    A LayoutTests/fast/images/valid-style-cross-fade.html
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/css/CSSCrossfadeValue.cpp
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+Image.cpp
    R Source/WebCore/css/parser/CSSPropertyParserConsumer+MetaTransformer.h

  Log Message:
  -----------
  CSS -webkit-cross-fade function should not eagerly evaluate calc()
https://bugs.webkit.org/show_bug.cgi?id=279029

Reviewed by Darin Adler.

Delays evaluation of calc() values in cross fade images to style
building. Removes last use of the parse time raw MetaTransformer,
which can now be retired.

* LayoutTests/fast/css/getComputedStyle/computed-style-cross-fade-expected.txt:
* LayoutTests/fast/css/getComputedStyle/computed-style-cross-fade.html:
* LayoutTests/fast/images/valid-style-cross-fade-expected.txt: Added.
* LayoutTests/fast/images/valid-style-cross-fade.html: Added.
    - Add / update tests with calc() cases.
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::createStyleImage const):
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Image.cpp:
(WebCore::CSSPropertyParserHelpers::consumeCrossFade):
* Source/WebCore/css/parser/CSSPropertyParserConsumer+MetaTransformer.h: Removed.

Canonical link: https://commits.webkit.org/283068@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list