[webkit-changes] [WebKit/WebKit] 73cf9d: [JSC] Make shared wasm entrypoint succinct

Yusuke Suzuki noreply at github.com
Sun Sep 1 21:54:03 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 73cf9deb7e468ec10eb51fc94663f2683d0e3ebd
      https://github.com/WebKit/WebKit/commit/73cf9deb7e468ec10eb51fc94663f2683d0e3ebd
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-09-01 (Sun, 01 Sep 2024)

  Changed paths:
    M Source/JavaScriptCore/jit/AssemblyHelpers.h
    M Source/JavaScriptCore/llint/WebAssembly.asm
    M Source/JavaScriptCore/wasm/WasmCallee.cpp
    M Source/JavaScriptCore/wasm/WasmCallee.h
    M Source/JavaScriptCore/wasm/js/JSToWasm.cpp
    M Source/JavaScriptCore/wasm/js/JSToWasm.h

  Log Message:
  -----------
  [JSC] Make shared wasm entrypoint succinct
https://bugs.webkit.org/show_bug.cgi?id=278978
rdar://135095645

Reviewed by Justin Michaud.

1. Do not use CCallHelper::Address { }, which is not consistent to the rest of the all JIT code.
2. Use CCallHelper::addressFor instead of directly pointing at sizeof(CPURegister) * n.
3. Use emitSaveCalleeSaveFor and emitRestoreCalleeSavesFor instead of doing them manually
4. Use cageConditionally.
5. Use lowestAccessibleAddress() directly. When emitting JIT code, it is already constant value.
6. Rename and drop "Interpreter" since it is no longer interpreter.

* Source/JavaScriptCore/jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::unboxNativeCallee):
(JSC::AssemblyHelpers::boxNativeCallee):
* Source/JavaScriptCore/wasm/WasmCallee.h:
* Source/JavaScriptCore/wasm/js/JSToWasm.cpp:
(JSC::Wasm::createJSToWasmJITInterpreter):

Canonical link: https://commits.webkit.org/283046@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list