[webkit-changes] [WebKit/WebKit] 00489f: [Flex] Hittest fails to find legend when fieldset ...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 00489fb244e13f4c4769f65589456c1684c89efe
      https://github.com/WebKit/WebKit/commit/00489fb244e13f4c4769f65589456c1684c89efe
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-09-01 (Sun, 01 Sep 2024)

  Changed paths:
    A LayoutTests/fast/flexbox/hittest-fieldset-as-flex-container-expected.txt
    A LayoutTests/fast/flexbox/hittest-fieldset-as-flex-container.html
    M Source/WebCore/rendering/RenderFlexibleBox.cpp

  Log Message:
  -----------
  [Flex] Hittest fails to find legend when fieldset is a flex box
https://bugs.webkit.org/show_bug.cgi?id=278981
<rdar://134975207>

Reviewed by Antti Koivisto.

Excluded children (e.g. <legend>) are not supposed to be excluded from hittest.
("isExcludedFromNormalLayout" as its name implies should only be excluded from (inflow) layout. This also matches BFC.)

* LayoutTests/fast/flexbox/hittest-fieldset-as-flex-container-expected.txt: Added.
* LayoutTests/fast/flexbox/hittest-fieldset-as-flex-container.html: Added.
* Source/WebCore/rendering/RenderFlexibleBox.cpp: Include children with isExcludedFromNormalLayout bit set (shouldSkipChild skips both out of flow and excluded flex items)
(WebCore::RenderFlexibleBox::hitTestChildren):

Canonical link: https://commits.webkit.org/283039@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications