[webkit-changes] [WebKit/WebKit] 1ce83d: Get hardware keyboard state off the main thread

Per Arne Vollan noreply at github.com
Sun Sep 1 08:39:15 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1ce83d6be586ef058792e65ad2895fafc05e3e2a
      https://github.com/WebKit/WebKit/commit/1ce83d6be586ef058792e65ad2895fafc05e3e2a
  Author: Per Arne Vollan <pvollan at apple.com>
  Date:   2024-09-01 (Sun, 01 Sep 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxyInternals.h
    M Source/WebKit/UIProcess/WebProcessPool.h
    M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm

  Log Message:
  -----------
  Get hardware keyboard state off the main thread
https://bugs.webkit.org/show_bug.cgi?id=278885
rdar://133245137

Reviewed by Chris Dumez.

In order to avoid blocking the main thread, get the hardware keyboard state off the main thread.
This is being done in the Web process pool, which holds the cached value for the keyboard state.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitialize):
(WebKit::WebProcessPool::cachedHardwareKeyboardState):
(WebKit::WebProcessPool::setCachedHardwareKeyboardState):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
* Source/WebKit/UIProcess/WebPageProxyInternals.h:
* Source/WebKit/UIProcess/WebProcessPool.h:
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::platformInitialize):
(WebKit::WebPageProxy::hardwareKeyboardAvailabilityChanged):

Canonical link: https://commits.webkit.org/283035@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list