[webkit-changes] [WebKit/WebKit] 315509: [css-masonry] Fix intrinsic-sizing-cols-004-mix1/2

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3155098264ca1dfb212ba388794b7a4d8aa9d81a
      https://github.com/WebKit/WebKit/commit/3155098264ca1dfb212ba388794b7a4d8aa9d81a
  Author: Brandon Stewart <brandonstewart at apple.com>
  Date:   2024-10-31 (Thu, 31 Oct 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-004-mix1-expected.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-004-mix1-ref.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-004-mix1.html
    M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp

  Log Message:
  -----------
  [css-masonry] Fix intrinsic-sizing-cols-004-mix1/2
https://bugs.webkit.org/show_bug.cgi?id=282340
rdar://problem/138927036

Reviewed by Sammy Gill.

During the stretch flexible tracks we need to take into account that indefinite items are also placed in each track.
This was being ignored before, which can cause differences in flex size computations.

Update mix1 test cases:

Test 2:
The "5 5" is set to a width of 2ch in the original test case.

Test 6:
An extra 5 was missing.

Test 9:
The last column should be ~3ch.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-004-mix1-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-004-mix1-ref.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-004-mix1.html:
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::IndefiniteSizeStrategy::accumulateFlexFractionMasonry const):
(WebCore::IndefiniteSizeStrategy::findUsedFlexFraction const):

Canonical link: https://commits.webkit.org/285993@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications